BC-8008 - Fix any type linter warning #3549

odalys-dataport · 2025-02-12T00:56:31Z

Short Description

Links to Ticket and related Pull-Requests

BC-8008

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

QA: In addition to review, the code has been manually tested (if manual testing is possible)
PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

…into BC-8008-eslint-any

…, FileStorageApi.composable.unit.ts

…urseRoomList

…into BC-8008-eslint-any

…tring[]

…nt.unit.ts

…per from setup function

…on to ISO string

…type and mockResource

…pe and the resource type definition

…ype assertion

MartinSchuhmacher

tests need some changing, will look into that

request fullfilled

src/store/accounts.ts

src/types/vuetify/index.ts

src/components/molecules/TaskItemStudent.unit.ts

src/pages/course-rooms/CourseRoomList.page.vue

uidp · 2025-02-24T15:58:37Z

src/store/env-config.unit.ts

@@ -45,12 +45,12 @@ describe("env-config module", () => {
 			describe("when configs loaded successfully", () => {
 				const setup = () => {
 					const serverConfigresponse = createMock<
-						AxiosResponse<ConfigResponse, any>
+						AxiosResponse<ConfigResponse, unknown>


The second type parameter defaults to any and therefore can be left out:

export interface AxiosResponse<T = any, D = any>

Just as a hint. Can be left "as-is".

src/store/filePaths.ts

uidp · 2025-02-24T16:06:45Z

src/store/finished-tasks.unit.ts

+				};
+
+				spy.mockReturnValue(
+					taskApiMock as unknown as serverApi.TaskApiInterface


Why remove the setup()? Couldn't we just do the type cast there?

src/store/import-users.ts

src/types/board/Board.ts

sonarqubecloud · 2025-02-26T11:01:13Z

Quality Gate failed

Failed conditions
77.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

odalys-dataport and others added 22 commits January 14, 2025 09:53

CommonCartridgeExportModal

7b0d04b

CommonCartridgeImportModal.unit.ts

88d8777

Merge branch 'main' of https://github.com/hpi-schul-cloud/nuxt-client …

305f404

…into BC-8008-eslint-any

remove any from InfoBox.unit.ts

827a040

remove any from TaskItemStuden.unit.ts

e125cf5

remove any from vImportUsersMatchSearch.unit.ts

6216c01

fix RoomDashboard.unit.ts, CollaborativeTextEditor.composable.unit.ts…

07009c7

…, FileStorageApi.composable.unit.ts

fix import-users.ts

36bc093

remove any from TimePicker.vue

fed9748

adjust PreviewImage

caac0ff

change systems any[] to SchoolSystemResponse[]

c5dca85

remove any from SchoolSettings, CourseRoomDetails.page.unit.ts and Co…

5493c45

…urseRoomList

Merge branch 'main' of https://github.com/hpi-schul-cloud/nuxt-client …

a36da0e

…into BC-8008-eslint-any

updated api.ts

fff286c

change type customEvent in default-wireframe.types.ts from any to string

a237d21

updated API TS

94651a8

Change the type of systems in SchoolSettings.page.vue from any[] to s…

886e1aa

…tring[]

Refactor mockSystems type in SchoolSettings.page.unit.ts

f43e298

Typing of autoLogout.ts

4d3e917

Typing of consoleErrorSpy in auth.unit.ts updated

87a3d88

Add @ts-expect-error comment to indicate type errors in TaskItemStude…

c0a9715

…nt.unit.ts

Refactor tests in BoardAnyTitleInput.unit.ts to use destructured wrap…

80037ba

…per from setup function

wolfganggreschus assigned wolfganggreschus and odalys-dataport Feb 13, 2025

wolfganggreschus added 6 commits February 13, 2025 10:54

Updated typing of dateTimeCombined in FormNews.vue and added conversi…

c154298

…on to ISO string

Remove unused type definitions from content.ts

255af42

Add type definitions for queries, resources and lessons in content.ts

cb4eb9d

Remove unused 'collection' property from Resource type and mockResource

ce722ee

Remove the properties 'createdAt' and 'modifiedAt' from the resource …

f162733

…type and mockResource

Remove the properties 'rating' and 'remote' from the mock resource ty…

1305571

…pe and the resource type definition

odalys-dataport marked this pull request as ready for review February 20, 2025 09:35

odalys-dataport added the auto-extend-activation-time label Feb 20, 2025

odalys-dataport and others added 3 commits February 20, 2025 11:23

fix import warnings in Board.ts

229e9b2

adjust type import to not cause error in CommonCartridgeExportModal t…

0e665fa

…ype assertion

adjusting ttl response for auto logout

9162455

MartinSchuhmacher mentioned this pull request Feb 21, 2025

BC-8416 - Auto logout in nuxt-client does not work #3563

Closed

3 tasks

MartinSchuhmacher approved these changes Feb 21, 2025

View reviewed changes

MartinSchuhmacher previously requested changes Feb 21, 2025

View reviewed changes

fixing test

3941125

odalys-dataport commented Feb 21, 2025

View reviewed changes

src/store/accounts.ts Show resolved Hide resolved

odalys-dataport and others added 2 commits February 24, 2025 09:36

Merge branch 'main' into BC-8008-eslint-any

844e5b0

adjusting type of DataTable to generic approach

9ba7f65

MartinSchuhmacher reviewed Feb 24, 2025

View reviewed changes

src/types/vuetify/index.ts Show resolved Hide resolved

MartinSchuhmacher and others added 2 commits February 24, 2025 13:38

fixing type errors

49cf5be

Merge branch 'main' into BC-8008-eslint-any

2c5cdfa