Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-6625 Incorrect text on management pages #3144

Merged
merged 12 commits into from
Mar 25, 2024
Merged

BC-6625 Incorrect text on management pages #3144

merged 12 commits into from
Mar 25, 2024

Conversation

KalliSfak
Copy link
Contributor

@KalliSfak KalliSfak commented Mar 13, 2024 •
edited
Loading

Short Description

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/BC-6625

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@KalliSfak KalliSfak self-assigned this Mar 13, 2024
bischofmax
bischofmax reviewed Mar 15, 2024
View reviewed changes
@KalliSfak KalliSfak requested a review from SevenWaysDP March 20, 2024 11:00
@KalliSfak KalliSfak enabled auto-merge (squash) March 25, 2024 13:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@KalliSfak KalliSfak merged commit 365b525 into main Mar 25, 2024
48 checks passed
@KalliSfak KalliSfak deleted the BC-6625-incorrect-text-management branch March 25, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bischofmax bischofmax bischofmax left review comments

@SevenWaysDP SevenWaysDP SevenWaysDP approved these changes

Assignees

@KalliSfak KalliSfak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KalliSfak @SevenWaysDP @bischofmax