Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-6505 - Change defaultwireframe overflow #3085

Merged

Conversation

bischofmax
Copy link
Contributor

@bischofmax bischofmax commented Feb 9, 2024

Short Description

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@bischofmax bischofmax self-assigned this Feb 9, 2024
@bischofmax bischofmax changed the base branch from main to BC-3844-vue3-webpack February 9, 2024 08:16
@@ -49,7 +49,9 @@
}"
class="main-content"
>
<slot />
<div style="padding: 0 var(--space-lg)">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wieso machst du das hier mit nem Inline Style und nicht mit ner CSS-Klasse?

@bischofmax bischofmax merged commit 8d76c29 into BC-3844-vue3-webpack Feb 12, 2024
32 of 37 checks passed
@bischofmax bischofmax deleted the BC-6505-change-defaultwireframe-overflow branch February 12, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants