Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-6512 - Vue3 upgrade: Fix room avatar access with keyboard #3081

Merged
merged 1 commit into from
Feb 8, 2024
Merged

BC-6512 - Vue3 upgrade: Fix room avatar access with keyboard #3081

merged 1 commit into from
Feb 8, 2024

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Feb 8, 2024 •
edited by atlldwp
Loading

Short Description

You can not reach the group avatar on course overview page via keyboard tabing, only the single courses.

Links to Ticket and related Pull-Requests

BC-6512

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@MartinSchuhmacher MartinSchuhmacher self-assigned this Feb 8, 2024
@MartinSchuhmacher MartinSchuhmacher changed the base branch from main to BC-3844-vue3-webpack February 8, 2024 14:20
virgilchiriac
virgilchiriac reviewed Feb 8, 2024
View reviewed changes
src/components/molecules/vRoomGroupAvatar.vue
@@ -32,6 +32,7 @@
@dragenter.prevent.stop="dragEnter"
@keypress.enter="$emit('clicked', data.id)"
role="button"
tabindex="0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MartinSchuhmacher MartinSchuhmacher added the waiting for review Someone should review this ASAP label Feb 8, 2024
@MartinSchuhmacher MartinSchuhmacher removed the waiting for review Someone should review this ASAP label Feb 8, 2024
@MartinSchuhmacher MartinSchuhmacher merged commit 3860503 into BC-3844-vue3-webpack Feb 8, 2024
62 of 77 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-6512-vue3-avatars-keyboard branch February 8, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virgilchiriac virgilchiriac virgilchiriac left review comments

@odalys-dataport odalys-dataport odalys-dataport approved these changes

Assignees

@MartinSchuhmacher MartinSchuhmacher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinSchuhmacher @virgilchiriac @odalys-dataport