Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-6171 - Vue3 upgrade: fix src/components/feature-board-external-tool-element tests #3033

Merged
merged 4 commits into from
Jan 23, 2024
Merged

BC-6171 - Vue3 upgrade: fix src/components/feature-board-external-tool-element tests #3033

merged 4 commits into from
Jan 23, 2024

Conversation

NFriedo
Copy link
Contributor

@NFriedo NFriedo commented Jan 23, 2024 •
edited
Loading

Short Description

Fix src/components/feature-board-external-tool-element tests

Links to Ticket and related Pull-Requests

BC-6171

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@NFriedo NFriedo added the WIP someone is working on that label Jan 23, 2024
@NFriedo NFriedo changed the base branch from main to BC-3844-vue3-webpack January 23, 2024 10:27
@NFriedo NFriedo added waiting for review Someone should review this ASAP and removed WIP someone is working on that labels Jan 23, 2024
@NFriedo NFriedo merged commit 0b51972 into BC-3844-vue3-webpack Jan 23, 2024
55 of 64 checks passed
@NFriedo NFriedo deleted the BC-6171-extools-board-tests branch January 23, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoeppner-dataport hoeppner-dataport hoeppner-dataport approved these changes

Assignees
No one assigned
Labels
waiting for review Someone should review this ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NFriedo @hoeppner-dataport