BC-6193 - vue3 fix UI light box #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SevenWaysDP
changed the base branch from
BC-6196-vue3-tests
to
BC-3844-vue3-webpack
bischofmax
reviewed
Jan 23, 2024
SevenWaysDP
commented
Jan 24, 2024
| @@ -66,14 +65,8 @@ export default defineComponent({ | |||
| imageSrc, | |||
| setError, | |||
| isError, | |||
| errorImage, | |||
There was a problem hiding this comment.
Suggested change
| errorImage, |
bischofmax
reviewed
Jan 24, 2024
| @@ -102,8 +102,6 @@ export default defineComponent({ | |||
| .display-container { | |||
| position: relative; | |||
| min-height: 52px; | |||
There was a problem hiding this comment.
Das gehört hier eigentlich auch nicht hin. Willst du das hier noch machen oder in der BC-6355?
This reverts commit 659872c.
bischofmax
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Links to Ticket and related Pull-Requests
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging