Skip to content

Commit

Permalink
BC-8262 - Fix scrolling for room overview (#3435)
Browse files Browse the repository at this point in the history
* set draggable to false as default for new room avatars to avoid scrolling bugs on mobile
  • Loading branch information
MartinSchuhmacher authored Nov 4, 2024
1 parent ba4b411 commit 6e158e0
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 9 deletions.
4 changes: 2 additions & 2 deletions src/locales/de.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1668,9 +1668,8 @@ export default {
"pages.roomDetails.ariaLabels.menu": "Raum-Menü",
"pages.roomDetails.ariaLabels.menu.action.edit": "Raum bearbeiten",
"pages.roomDetails.ariaLabels.menu.action.delete": "Raum löschen",
"pages.rooms.title": "Räume",
"pages.rooms.fab.title": "Raum erstellen",
"pages.rooms.emptyState": "Aktuell gibt es hier noch keine Räume.",
"pages.rooms.fab.title": "Raum erstellen",
"pages.rooms.participant.error.load":
"Die Teilnehmenden-Liste konnte nicht geladen werden.",
"pages.rooms.participant.error.add":
Expand All @@ -1690,6 +1689,7 @@ export default {
"Einträge pro Seite",
"pages.rooms.participants.roles.editor": "Raumeditor",
"pages.rooms.participants.roles.viewer": "Raumbetrachter",
"pages.rooms.title": "Räume",
"pages.taskCard.addElement": "Element hinzufügen",
"pages.taskCard.deleteElement.text":
"Bist du dir sicher, dass du das Element löschen möchtest?",
Expand Down
4 changes: 2 additions & 2 deletions src/locales/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1640,9 +1640,8 @@ export default {
"pages.roomDetails.ariaLabels.menu": "Room menu",
"pages.roomDetails.ariaLabels.menu.action.edit": "Edit room",
"pages.roomDetails.ariaLabels.menu.action.delete": "Delete room",
"pages.rooms.title": "Rooms",
"pages.rooms.fab.title": "Create room",
"pages.rooms.emptyState": "Currently there are no rooms here.",
"pages.rooms.fab.title": "Create room",
"pages.rooms.participant.error.load":
"The participant list could not be loaded.",
"pages.rooms.participant.error.add": "Adding participants failed.",
Expand All @@ -1659,6 +1658,7 @@ export default {
"pages.rooms.participants.participantTable.itemsPerPage": "Entries per page",
"pages.rooms.participants.roles.editor": "Room editor",
"pages.rooms.participants.roles.viewer": "Room viewer",
"pages.rooms.title": "Rooms",
"pages.taskCard.addElement": "Add element",
"pages.taskCard.deleteElement.text":
"Are you sure, you want to remove this element?",
Expand Down
4 changes: 2 additions & 2 deletions src/locales/es.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1684,9 +1684,8 @@ export default {
"pages.roomDetails.ariaLabels.menu": "Menú de la habitación",
"pages.roomDetails.ariaLabels.menu.action.edit": "Editar habitación",
"pages.roomDetails.ariaLabels.menu.action.delete": "Borrar habitación",
"pages.rooms.title": "Habitaciones",
"pages.rooms.fab.title": "Crear habitación",
"pages.rooms.emptyState": "Actualmente no hay habitaciones aquí.",
"pages.rooms.fab.title": "Crear habitación",
"pages.rooms.participant.error.load":
"No se pudo cargar la lista de participantes.",
"pages.rooms.participant.error.add": "Error al agregar participantes.",
Expand All @@ -1704,6 +1703,7 @@ export default {
"Entradas por página",
"pages.rooms.participants.roles.editor": "Editor de salas",
"pages.rooms.participants.roles.viewer": "Visor de salas",
"pages.rooms.title": "Habitaciones",
"pages.taskCard.addElement": "Añadir artículo",
"pages.taskCard.deleteElement.text":
"¿Estás seguro de que deseas eliminar este elemento?",
Expand Down
4 changes: 2 additions & 2 deletions src/locales/uk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1662,9 +1662,8 @@ export default {
"pages.roomDetails.ariaLabels.menu": "Меню кімнати",
"pages.roomDetails.ariaLabels.menu.action.edit": "Кімната редагування",
"pages.roomDetails.ariaLabels.menu.action.delete": "Видалити кімнату",
"pages.rooms.title": "Кімнати",
"pages.rooms.fab.title": "Створити кімнату",
"pages.rooms.emptyState": "Зараз тут немає кімнат",
"pages.rooms.fab.title": "Створити кімнату",
"pages.rooms.participant.error.load":
"Не вдалося завантажити список учасників.",
"pages.rooms.participant.error.add": "Не вдалося додати учасників.",
Expand All @@ -1682,6 +1681,7 @@ export default {
"Записи на сторінку",
"pages.rooms.participants.roles.editor": "Редактор кімнати",
"pages.rooms.participants.roles.viewer": "Переглядач кімнати",
"pages.rooms.title": "Кімнати",
"pages.taskCard.addElement": "Додати елемент",
"pages.taskCard.deleteElement.text":
"Ви впевнені, що хочете видалити цей елемент?",
Expand Down
7 changes: 6 additions & 1 deletion src/modules/feature/room/RoomTile.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
<template>
<RouterLink :to="roomPath" class="room-link" :aria-label="avatarAriaLabel">
<RouterLink
:to="roomPath"
class="room-link"
:aria-label="avatarAriaLabel"
draggable="false"
>
<div class="room-avatar" :class="avatarColor">
<span class="text-h3 text-white" data-testid="room-short-title">
{{ roomShortName }}
Expand Down

0 comments on commit 6e158e0

Please sign in to comment.