BC-7239 - fix sonar complain

hpi-schul-cloud · Jun 25, 2024 · 2dadc66 · 2dadc66
1 parent 5d444d4
commit 2dadc66
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/main/java/de/svs/doido/mongo/kubernetes/configmap/Write.java b/src/main/java/de/svs/doido/mongo/kubernetes/configmap/Write.java
@@ -14,6 +14,9 @@
 @RequestScoped
 public class Write {
 
+    private static final String NAME_LABEL = "app.kubernetes.io/name";
+    private static final String NAME_LABEL_VALUE = "doido-mongo";
+
     @Inject
     KubernetesClient client;
 
@@ -26,8 +29,8 @@ public boolean writeConfigmap(String namespace, Configmap cfg) {
         if(configmap != null) {
             labels = configmap.getMetadata().getLabels();
             if( 
-                labels.containsKey("app.kubernetes.io/name") &&
-                labels.get("app.kubernetes.io/name").equals("doido-mongo")
+                labels.containsKey(NAME_LABEL) &&
+                labels.get(NAME_LABEL).equals(NAME_LABEL_VALUE)
             ) {
                 data = configmap.getData();
                 data.put("uri", cfg.getUri());
@@ -42,7 +45,7 @@ public boolean writeConfigmap(String namespace, Configmap cfg) {
         else {
             labels = new HashMap<>();
             data = new HashMap<>();
-            labels.put("app.kubernetes.io/name", "doido-mongo");
+            labels.put(NAME_LABEL, NAME_LABEL_VALUE);
             data.put("uri", cfg.getUri());
             configmap = new ConfigMapBuilder().withNewMetadata().withName(cfg.getName()).withNamespace(namespace).and().build();
             configmap.setData(data);