Ensure tests are properly cleaned up

[finishes #151803941]

Signed-off-by: Danail Branekov <[email protected]>

gqt/runtime_plugin_test.go

@@ -101,6 +101,10 @@ var _ = Describe("Runtime Plugin", func() {
 					config.NetworkPluginExtraArgs = []string{networkPluginArgsFile, os.DevNull, "unused"}
 				})
 
+				AfterEach(func() {
+					Expect(os.Remove(networkPluginArgsFile)).To(Succeed())
+				})
+
 				JustBeforeEach(func() {
 					Expect(ioutil.WriteFile(
 						filepath.Join(client.TmpDir, "runtime-state-output"),

properties/manager_test.go

@@ -164,9 +164,10 @@ var _ = Describe("Properties", func() {
 
 			tmp, err = os.Open(tmp.Name())
 			Expect(err).NotTo(HaveOccurred())
-
 			var roundtripped properties.Manager
 			Expect(json.NewDecoder(tmp).Decode(&roundtripped)).To(Succeed())
+			Expect(tmp.Close()).To(Succeed())
+			Expect(os.Remove(tmp.Name())).To(Succeed())
 
 			val, ok := roundtripped.Get("foo", "bar")
 			Expect(ok).To(BeTrue())

rundmc/runrunc/create_test.go

@@ -56,10 +56,15 @@ var _ = Describe("Create", func() {
 			Expect(err).NotTo(HaveOccurred())
 			_, err = io.Copy(logFile, strings.NewReader(logs))
 			Expect(err).NotTo(HaveOccurred())
+			Expect(logFile.Close()).To(Succeed())
 			return runcExitStatus
 		})
 	})
 
+	AfterEach(func() {
+		Expect(os.RemoveAll(bundlePath)).To(Succeed())
+	})
+
 	It("creates the container with runC create", func() {
 		Expect(runner.Create(logger, bundlePath, "some-id", garden.ProcessIO{})).To(Succeed())
 

rundmc/runrunc/exec_test.go

@@ -134,6 +134,10 @@ var _ = Describe("ExecPreparer", func() {
 		preparer = runrunc.NewExecPreparer(bundleLoader, users, enver, mkdirer, []string{"foo", "bar", "brains"}, runningAsRoot)
 	})
 
+	AfterEach(func() {
+		Expect(os.RemoveAll(bundlePath)).To(Succeed())
+	})
+
 	It("passes a process.json with the correct path and args", func() {
 		spec, err := preparer.Prepare(logger, bundlePath, garden.ProcessSpec{Path: "to enlightenment", Args: []string{"infinity", "and beyond"}})
 		Expect(err).NotTo(HaveOccurred())

rundmc/runrunc/log_test.go

@@ -41,6 +41,13 @@ var _ = Describe("RunAndLog", func() {
 		})
 	})
 
+	AfterEach(func() {
+		if _, err := os.Stat(logFile.Name()); err == nil {
+			Expect(logFile.Close()).To(Succeed())
+			Expect(os.Remove(logFile.Name())).To(Succeed())
+		}
+	})
+
 	It("execs the command", func() {
 		Expect(logRunner.RunAndLog(logger, func(logFile string) *exec.Cmd {
 			return exec.Command("something.exe")

rundmc/stopper/resolver.go

@@ -25,6 +25,7 @@ func (r resolver) Resolve(name, subsystem string) (string, error) {
 	if err != nil {
 		return "", err
 	}
+	defer stateJson.Close()
 
 	var s state
 	if err := json.NewDecoder(stateJson).Decode(&s); err != nil {

rundmc/stopper/resolver_test.go

@@ -32,7 +32,7 @@ var _ = Describe("Resolver", func() {
 	})
 
 	AfterEach(func() {
-		os.RemoveAll(fakeStateDir)
+		Expect(os.RemoveAll(fakeStateDir)).To(Succeed())
 	})
 
 	Context("with valid state.json", func() {