Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow management of DPL inverters while DPL is off #1525

Merged

Conversation

schlimmchen
Copy link
Member

we do allow to send limit updates and to start or stop the inverter using the web UI or MQTT payloads or any other supported mean even if this inverter is governed by the DPL, while the DPL is disabled. this is also documented explicitly (see DPL mode MQTT docs).

after implementing support for multiple inverters, this behavior changed unintentionally. this changeset makes sure that inverters are shut down once when the DPL dis disabled, but are left alone afterwards for as long as the DPL is disabled.

closes #1521.

we do allow to send limit updates and to start or stop the inverter
using the web UI or MQTT payloads or any other supported mean even if
this inverter is governed by the DPL, while the DPL is disabled. this
is also documented explicitly (see DPL mode MQTT docs).

after implementing support for multiple inverters, this behavior changed
unintentionally. this changeset makes sure that inverters are shut down
once when the DPL dis disabled, but are left alone afterwards for as
long as the DPL is disabled.
Copy link
Member

@AndreasBoehm AndreasBoehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected 👍

@schlimmchen schlimmchen merged commit c1a318f into development Jan 12, 2025
16 checks passed
@schlimmchen schlimmchen deleted the schlimmchen/fix/dpl-single-inverter-shutdown branch January 12, 2025 13:53
@AndreasBoehm
Copy link
Member

This fix only works for battery powered inverters.
With solar powered inverters we are stuck, the DPL is waiting for the inverter to shutdown, but we never shutdown solar inverters.

Should i create a new issue for this?

Log

10:21:09.632 > [DPL] targeting 0 W, base load is 1600 W, power meter reads 0.0 W (stale)
10:21:09.655 > [DPL] requesting 1600 W from 1 solar-powered inverter currently producing 641 W (diff 959 W, hysteresis 10 W)
10:21:09.664 > [DPL] will cover 641 W using 1 solar-powered inverter
10:21:09.673 > [DPL] battery allowance is 0/0 W DC/AC, solar power is 0/0 W DC/AC, requested are 959 W AC
10:21:09.682 > [DPL] requesting 0 W from 0 battery-powered inverters currently producing 0 W (diff 0 W, hysteresis 10 W)
10:21:09.691 > [DPL inverter 116494200313]:
10:21:09.700 >     solar-powered, producing 641 W
10:21:09.721 >     lower/current/upper limit: 52/1035/1600 W, output capability: 1600 W
10:21:09.732 >     sending commands enabled, reachable, eligible
10:21:09.755 >     max reduction production/standby: 589/589 W, max increase: 0 W
10:21:09.764 >     target limit/output/state: -1 W (unchanged)/641 W/unchanged, 0 update timeouts
10:21:09.773 >     MPPTs AC power: a: 41 W b: 241 W c: 240 W d: 119 W
10:21:09.809 > [DPL] the system is stable, the last power limit is still valid
10:21:09.944 > [DPL] disabled by configuration
10:21:10.114 > [DPL inverter 116494200313]: sending limit of 3.2 % (52 W respectively), max output is 1600 W
10:21:10.132 > Success
10:21:10.155 > [DPL] waiting for a start/stop/restart/limit command to complete
10:21:12.181 > Success
10:21:12.190 > Fetch inverter: 116494200313
10:21:12.199 > [DPL inverter 116494200313]: actual limit is 3.2 % (51 W respectively), effective 2244 ms after update started, requested were 3.2 %
10:21:12.210 > [DPL] disabled by configuration
10:21:12.219 > [DPL inverter 116494200313]: sending limit of 3.2 % (52 W respectively), max output is 1600 W
10:21:12.228 > [DPL] waiting for a start/stop/restart/limit command to complete
10:21:12.790 > Success
10:21:14.770 > Success
10:21:14.785 > Fetch inverter: 116494200313
10:21:14.798 > [DPL inverter 116494200313]: actual limit is 3.2 % (51 W respectively), effective 2582 ms after update started, requested were 3.2 %
10:21:14.823 > [DPL] disabled by configuration
10:21:14.841 > [DPL inverter 116494200313]: sending limit of 3.2 % (52 W respectively), max output is 1600 W
10:21:14.863 > [DPL] waiting for a start/stop/restart/limit command to complete
10:21:15.349 > Success
10:21:17.350 > Success
10:21:17.362 > Fetch inverter: 116494200313
10:21:17.371 > [DPL inverter 116494200313]: actual limit is 3.2 % (51 W respectively), effective 2581 ms after update started, requested were 3.2 %
10:21:17.385 > [DPL] disabled by configuration
10:21:17.401 > [DPL inverter 116494200313]: sending limit of 3.2 % (52 W respectively), max output is 1600 W
10:21:17.411 > [DPL] waiting for a start/stop/restart/limit command to complete
10:21:17.670 > Websocket: [/livedata][8] connect
10:21:18.011 > Success
10:21:19.958 > Success
10:21:20.066 > Fetch inverter: 116494200313
10:21:20.106 > [DPL inverter 116494200313]: actual limit is 3.2 % (51 W respectively), effective 2582 ms after update started, requested were 3.2 %
10:21:20.145 > [DPL] disabled by configuration
10:21:20.188 > [DPL inverter 116494200313]: sending limit of 3.2 % (52 W respectively), max output is 1600 W
10:21:20.227 > [DPL] waiting for a start/stop/restart/limit command to complete
10:21:20.571 > Success
10:21:22.545 > Success
10:21:22.665 > Fetch inverter: 116494200313
10:21:22.743 > [DPL inverter 116494200313]: actual limit is 3.2 % (51 W respectively), effective 2582 ms after update started, requested were 3.2 %
10:21:22.825 > [DPL] disabled by configuration
10:21:22.943 > [DPL inverter 116494200313]: sending limit of 3.2 % (52 W respectively), max output is 1600 W
10:21:22.986 > [DPL] waiting for a start/stop/restart/limit command to complete
10:21:23.063 > Success
10:21:25.182 > Success
10:21:25.305 > Fetch inverter: 116494200313
10:21:25.384 > [DPL inverter 116494200313]: actual limit is 3.2 % (51 W respectively), effective 2580 ms after update started, requested were 3.2 %
10:21:25.505 > [DPL] disabled by configuration
10:21:25.583 > [DPL inverter 116494200313]: sending limit of 3.2 % (52 W respectively), max output is 1600 W
10:21:25.708 > [DPL] waiting for a start/stop/restart/limit command to complete
10:21:25.745 > Success
10:21:27.728 > Success
10:21:27.865 > Fetch inverter: 116494200313
10:21:27.943 > [DPL inverter 116494200313]: actual limit is 3.2 % (51 W respectively), effective 2581 ms after update started, requested were 3.2 %
10:21:28.065 > [DPL] disabled by configuration
10:21:28.106 > [DPL inverter 116494200313]: sending limit of 3.2 % (52 W respectively), max output is 1600 W
10:21:28.186 > [DPL] waiting for a start/stop/restart/limit command to complete
10:21:28.264 > Success
10:21:30.402 > Success
10:21:30.545 > Fetch inverter: 116494200313
10:21:30.623 > [DPL inverter 116494200313]: actual limit is 3.2 % (51 W respectively), effective 2580 ms after update started, requested were 3.2 %
10:21:30.744 > [DPL] disabled by configuration
10:21:30.827 > [DPL inverter 116494200313]: sending limit of 3.2 % (52 W respectively), max output is 1600 W
10:21:30.903 > [DPL] waiting for a start/stop/restart/limit command to complete
10:21:31.065 > Success

@schlimmchen
Copy link
Member Author

@AndreasBoehm Adressed (fixed) in 5944413 (pushed to development).

@AndreasBoehm
Copy link
Member

Works as expected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DPL] Unable to control inverter manually
2 participants