-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: allow management of DPL inverters while DPL is off #1525
Fix: allow management of DPL inverters while DPL is off #1525
Conversation
we do allow to send limit updates and to start or stop the inverter using the web UI or MQTT payloads or any other supported mean even if this inverter is governed by the DPL, while the DPL is disabled. this is also documented explicitly (see DPL mode MQTT docs). after implementing support for multiple inverters, this behavior changed unintentionally. this changeset makes sure that inverters are shut down once when the DPL dis disabled, but are left alone afterwards for as long as the DPL is disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as expected 👍
This fix only works for battery powered inverters. Should i create a new issue for this? Log
|
@AndreasBoehm Adressed (fixed) in 5944413 (pushed to development). |
Works as expected 👍 |
we do allow to send limit updates and to start or stop the inverter using the web UI or MQTT payloads or any other supported mean even if this inverter is governed by the DPL, while the DPL is disabled. this is also documented explicitly (see DPL mode MQTT docs).
after implementing support for multiple inverters, this behavior changed unintentionally. this changeset makes sure that inverters are shut down once when the DPL dis disabled, but are left alone afterwards for as long as the DPL is disabled.
closes #1521.