remove default declarations from the Stats.h base class

hoylabs · Feb 4, 2025 · fd60dbc · fd60dbc
1 parent 475408b
commit fd60dbc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/include/solarcharger/Stats.h b/include/solarcharger/Stats.h
@@ -28,13 +28,13 @@ class Stats {
 
     // state of operation from the first available controller
     enum class StateOfOperation : uint8_t { Off = 0, Bulk = 1, Absorption = 2, Float = 3, Various = 255 };
-    virtual std::optional<Stats::StateOfOperation> getStateOfOperation() const { return std::nullopt; };
+    virtual std::optional<Stats::StateOfOperation> getStateOfOperation() const;
 
     // float voltage from the first available charge controller
-    virtual std::optional<float> getFloatVoltage() const { return std::nullopt; };
+    virtual std::optional<float> getFloatVoltage() const;
 
     // absorption voltage from the first available charge controller
-    virtual std::optional<float> getAbsorptionVoltage() const { return std::nullopt; };
+    virtual std::optional<float> getAbsorptionVoltage() const;
 
     // convert stats to JSON for web application live view
     virtual void getLiveViewData(JsonVariant& root, const boolean fullUpdate, const uint32_t lastPublish) const;

diff --git a/include/solarcharger/mqtt/Stats.h b/include/solarcharger/mqtt/Stats.h
@@ -17,6 +17,9 @@ friend class Provider;
     std::optional<uint16_t> getPanelPowerWatts() const final { return std::nullopt; }
     std::optional<float> getYieldTotal() const final { return std::nullopt; }
     std::optional<float> getYieldDay() const final { return std::nullopt; }
+    std::optional<StateOfOperation> getStateOfOperation() const final { return std::nullopt; }
+    std::optional<float> getFloatVoltage() const final { return std::nullopt; }
+    std::optional<float> getAbsorptionVoltage() const final { return std::nullopt; }
 
     void getLiveViewData(JsonVariant& root, const boolean fullUpdate, const uint32_t lastPublish) const final;