Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(types): Add Handler type #4

Merged
merged 1 commit into from
Jun 13, 2019
Merged

feature(types): Add Handler type #4

merged 1 commit into from
Jun 13, 2019

Conversation

gillchristian
Copy link
Contributor

Handler type can be used when you don't want to define the handlers inline

@gillchristian gillchristian requested a review from dmitrika June 13, 2019 11:43
@gillchristian
Copy link
Contributor Author

@raybooysen added the Handler type mentioned in Hotell/rex-tils#23 (comment)

@gillchristian gillchristian mentioned this pull request Jun 13, 2019
Open
dmitrika
dmitrika approved these changes Jun 13, 2019
View reviewed changes
Copy link

@dmitrika dmitrika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@gillchristian gillchristian merged commit fc4aa9a into master Jun 13, 2019
@gillchristian gillchristian deleted the feature/handler-type branch June 13, 2019 13:37
@gillchristian
Copy link
Contributor Author

Released 89c3f0e

@raybooysen
Copy link

@gillchristian thank you for this.

In my project, I'm using immer to handle mutation of a draft of the state. Would you be open to taking a PR that adds sibling functions that match your Handler, and handleActions functions that match the immer requirement?

I'm not sure how we could let them live side-by-side, maybe as a safe-redux-immer package?

@gillchristian
Copy link
Contributor Author

If you open an issue explaining a bit more we can discuss there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrika dmitrika dmitrika approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gillchristian @raybooysen @dmitrika