Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rapid to v2 #6054

Merged
merged 21 commits into from
Dec 1, 2023
Merged

Update Rapid to v2 #6054

merged 21 commits into from
Dec 1, 2023

Conversation

tsmock
Copy link
Contributor

@tsmock tsmock commented Sep 8, 2023 •
edited
Loading

  • Use URL hash params for Rapid settings
    • This reduces fragility going forward since we don't have to worry about internal Rapid changes as much
  • Use a CDN for Rapid script and data
    • This is set to a semver patch range for the Rapid version. This means that if there is a patch release, we don't have to update Rapid and do a release. It was not a semver minor version since there were some internal Rapid changes that broke some of the code that we were using.
  • Saves dom node to avoid recreating Rapid
    • Otherwise, switching between tasks can be tricky

I've tried to document everything.

@github-actions github-actions bot added scope: frontend dependencies Pull requests that update a dependency file javascript labels Sep 8, 2023
@tsmock tsmock force-pushed the chore/update-rapid branch from b703e6d to 186972f Compare September 8, 2023 15:42
@tsmock tsmock marked this pull request as ready for review September 11, 2023 15:03
@tsmock tsmock force-pushed the chore/update-rapid branch from 0a88b11 to 38d893b Compare October 16, 2023 12:41
@royallsilwallz
Copy link
Contributor

royallsilwallz commented Oct 20, 2023 •
edited
Loading

Hey @tsmock, I've reviewed the PR and it seems to work perfectly fine. I think it is ready to merge.

Regarding the SonarCloud Code Analysis quality gate failure - the linter is showing warnings on the docker files.
I don't think this should block us from merging the code since we have manual build setup and the warning on docker files should not affect the build process.

Furthermore, @mahesh-naxa is working on fixing these errors as well in this PR.

CC @ramyaragupathy @manjitapandey @varun2948 @konishon

@tsmock tsmock force-pushed the chore/update-rapid branch from 645239f to b20d0e5 Compare November 13, 2023 14:28
@royallsilwallz
Copy link
Contributor

royallsilwallz commented Nov 23, 2023 •
edited
Loading

Hey @tsmock, after your latest push last week, one of the test case is failing. Do you have time to look into it?

Bonkles and others added 20 commits November 27, 2023 09:22
@Bonkles @tsmock
Remove references to rapid context methods that no longer exist.
238e567
@tsmock
Rapid v2: Show the GPX data
a177c4f 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Fix NPE in rapidEditor
df2849a 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid updates
0fe1823 
Signed-off-by: Taylor Smock <[email protected]>
@Bonkles @tsmock
Bump rapid version to 2.0.3, also make use of imagery and init promis…
f12712a 
…es to perform imagery switching at startup time. Also, rewrite history change to use URLSearchParams to replace existing Bing Param, if any.
@Bonkles @tsmock
Fix bug that would cause the 'custom editor' useEffect code to fire e…
bb81204 
…ven though no custom imagery source was defined.
@tsmock
Update yarn.lock
b2a0ebe 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Update for next Rapid version
7aedba9 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Update Rapid to v2.1.1
d56d40f 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Use system interface for setting up Rapid
35b3e2d 
Also, import Rapid from CDN instead of bundling it with the TM.
We still have to bundle the Rapid CSS file -- initial try on
importing the CSS file from the CDN failed. If that is fixed,
we could use a semver query for the CDN version, and get minor
Rapid updates for "free".

Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Load css and data resources from CDN
d3eddb9 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Fix issue where toggling sidebar would lose data, ensure mapvi…
5e5b5ad 
…ew is resized

Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Don't try to upload to sentry if we aren't logged in
8b6c267 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Fix preauth
c024ce0 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Use URL hash parameters instead of function calls
b33d5ac 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Get it working between task switches
8d22791 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Store dom node in state for reuse
ce11c1a 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Export functions that may be useful for iD and add basic tests…
ac1b842 
… for some of those functions

Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Listen for reset events to update task state disable state
b120d32 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
rapid: Add PropTypes for SonarLint
0b66836 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock tsmock force-pushed the chore/update-rapid branch from b20d0e5 to 5e32f43 Compare November 28, 2023 13:24
@tsmock tsmock force-pushed the chore/update-rapid branch from 5e32f43 to 4c5962e Compare November 28, 2023 19:56
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 28 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ramyaragupathy ramyaragupathy merged commit c2558e1 into hotosm:develop Dec 1, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file scope: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsmock @royallsilwallz @ramyaragupathy @Bonkles