Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TMS issues by using go-tilepacks and go-pmtiles #2162

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Work for #2157

Describe this PR

  • Fixes the TMS issues once and for all!
  • go-tilepacks is much better than basemapper.py at generating mbtiles - so much faster and better at handling different formats.
  • I also fixed an issue where the encoding is gzipped from servers: this was a problem for the Tokha TMS server (perhaps relay this info to devops, as it's useful to know! TMS server responses can be gzipped, but the receiving software needs to be able to decode the data). In some cases, it might be good to simply remove the gzip encoding from the responses.
  • Also includes go-pmtiles to do the conversion to pmtile format.
  • osm_fieldwork.basemapper.py is no longer used.

Screenshots

image

Additional Considerations

  • I'm sure this is probably quite CPU and memory intensive - I haven't tested thoroughly.
  • It might lock up the worker / thread until done. Luckily it's reasonably quick (<1min generally).
  • Might need to be tested if we experience issues!
  • In future this will be migrated to the https://github.com/hotosm/basemap-api microservice anyway.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock added this to the (v2025.2.0) future release milestone Feb 7, 2025
@spwoodcock spwoodcock requested a review from Sujanadh February 7, 2025 21:42
@spwoodcock spwoodcock self-assigned this Feb 7, 2025
@github-actions github-actions bot added bug Something isn't working backend Related to backend code contrib External contributions, or not related to core functionality labels Feb 7, 2025
@spwoodcock spwoodcock changed the title Fix/tms tilepacks Fix TMS issues by using go-tilepacks and go-pmtiles Feb 7, 2025
@Sujanadh
Copy link
Collaborator

Great work πŸŽ‰ I tested using all the tile sources, and performance is so great; it was quick.
The only issue is that the Bing source doesn't work, which you also have mentioned in the comment line. My device got frozen sometimes, maybe due to its CPU usage; not sure. Besides that, it works really well. πŸ‘

@spwoodcock spwoodcock merged commit 5dbd1cd into development Feb 10, 2025
5 checks passed
@spwoodcock spwoodcock deleted the fix/tms-tilepacks branch February 10, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working contrib External contributions, or not related to core functionality
Projects
Development

Successfully merging this pull request may close these issues.

2 participants