Feat validating admission webhook #207
Conversation
Signed-off-by: xu.zhu <[email protected]>
Signed-off-by: xu.zhu <[email protected]>
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
|
|
||
| // Get sends the admission request to the webhook server and returns the response | ||
| func (c *HTTPAdmissionClient) Get(ctx context.Context, admitData *Request) (*Response, error) { |
There was a problem hiding this comment.
Method HTTPAdmissionClient.Get has 6 return statements (exceeds 4 allowed).
| Interest(*Request) bool | ||
| } | ||
|
|
||
| func Validating(ctx context.Context, request *Request) error { |
There was a problem hiding this comment.
Function Validating has 7 return statements (exceeds 4 allowed).
| Interest(*Request) bool | ||
| } | ||
|
|
||
| func Validating(ctx context.Context, request *Request) error { |
There was a problem hiding this comment.
Function Validating has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
xuzhu-591
force-pushed
the
feat-validating-admission-webhook
branch
2 times, most recently
from
be770ae to
6add4c5
Compare
xuzhu-591
force-pushed
the
feat-validating-admission-webhook
branch
from
6add4c5 to
9944bbb
Compare
| Interest(*Request) bool | ||
| } | ||
|
|
||
| func Validating(ctx context.Context, request *Request) error { |
There was a problem hiding this comment.
Function Validating has 8 return statements (exceeds 4 allowed).
| Interest(*Request) bool | ||
| } | ||
|
|
||
| func Validating(ctx context.Context, request *Request) error { |
There was a problem hiding this comment.
Function Validating has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
Signed-off-by: xu.zhu <[email protected]>
xuzhu-591
force-pushed
the
feat-validating-admission-webhook
branch
from
9944bbb to
b2ec543
Compare
| ) | ||
|
|
||
| // Middleware to validate and mutate admission request | ||
| func Middleware(skippers ...middleware.Skipper) gin.HandlerFunc { |
There was a problem hiding this comment.
Function Middleware has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
| ) | ||
|
|
||
| // Middleware to validate and mutate admission request | ||
| func Middleware(skippers ...middleware.Skipper) gin.HandlerFunc { |
There was a problem hiding this comment.
Function Middleware has 53 lines of code (exceeds 50 allowed). Consider refactoring.
pkg/admission/webhook.go
Outdated
| } | ||
| } | ||
|
|
||
| func Clear() { |
| Interest(*Request) bool | ||
| } | ||
|
|
||
| func Validating(ctx context.Context, request *Request) error { |
There was a problem hiding this comment.
Function Validating has 51 lines of code (exceeds 50 allowed). Consider refactoring.
| ) | ||
|
|
||
| // Middleware to validate and mutate admission request | ||
| func Middleware(skippers ...middleware.Skipper) gin.HandlerFunc { |
There was a problem hiding this comment.
Function Middleware has 56 lines of code (exceeds 50 allowed). Consider refactoring.
Signed-off-by: xu.zhu <[email protected]>
xuzhu-591
force-pushed
the
feat-validating-admission-webhook
branch
from
7226cce to
f8e5e61
Compare
| ) | ||
|
|
||
| // Middleware to validate and mutate admission request | ||
| func Middleware(skippers ...middleware.Skipper) gin.HandlerFunc { |
There was a problem hiding this comment.
Function Middleware has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
|
Code Climate has analyzed commit f8e5e61 and detected 6 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 74.9% (60% is the threshold). This pull request will bring the total coverage in the repository to 66.3% (0.0% change). View more on Code Climate. |
| @@ -624,7 +631,8 @@ func Init(ctx context.Context, flags *Flags, coreConfig *config.Config) { | |||
| middleware.MethodAndPathSkipper(http.MethodPost, regexp.MustCompile("^/apis/core/v[12]/users/login"))), | |||
| prehandlemiddle.Middleware(r, manager), | |||
| auth.Middleware(rbacAuthorizer, authzSkippers...), | |||
| tagmiddle.Middleware(), // tag middleware, parse and attach tagSelector to context | |||
| tagmiddle.Middleware(), | |||
Description of your changes
Fixes #
I have:
make build && make lintto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer