Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On our project we wanted to migrate to Typescript 5.4 but we encountered the following issue
So here is a PR to fix it.
To do it, I've locally bumped the Typescript version used to 5.4.5, created the test case and fixed the issue to use the right method.
I didn't want to upgrade the Typescript version in your
package.json
as I didn't know if you want to run further tests to declare your package compatible. If you want me to do it, let me know and I'll push an extra commit