Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add support for culture/language like fr-FR #20

Closed
wants to merge 2 commits into from

Conversation

hongymagic
Copy link
Owner

@hongymagic hongymagic commented May 4, 2016

Changes dependency from much outdated numeral.js to numbro.js, and add optional culture property.

<NumberInput {...props} culture="fr-FR" />

DEMO

https://cdn.rawgit.com/hongymagic/react-number-input/feature/numbro/demos/demo0/index.html

TODO

  • Culture tests
  • Loading all the cultures are expensive and heavy; may need to rework that (demos0/demo0/all.js sitting at 60kb)

But everything seems to work ok now.

Fixed #12, #14

@hongymagic hongymagic self-assigned this May 4, 2016
@hongymagic hongymagic added this to the v15.0.0 milestone May 4, 2016
@hongymagic hongymagic force-pushed the feature/numbro branch 2 times, most recently from 0f8ff9e to e9414f1 Compare May 4, 2016 22:32
- Add culture selector on demo0 page
@hongymagic hongymagic closed this Mar 15, 2017
@hongymagic hongymagic deleted the feature/numbro branch March 15, 2017 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant