Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix AvailableMemory parsing on the cmd line #875

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix: Fix AvailableMemory parsing on the cmd line #875

merged 1 commit into from
Oct 26, 2023

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Change AvailableMemory in cmdenv to be type MemorySize
  • Implement flags.Unmarshaler so the flags system uses it
  • Add a test to make sure it works

Fixes #857

@kentquirk kentquirk added this to the v2.2 milestone Oct 16, 2023
@kentquirk kentquirk requested a review from a team as a code owner October 16, 2023 01:49
@kentquirk kentquirk changed the title [fix] Fix AvailableMemory parsing on the cmd line fix: Fix AvailableMemory parsing on the cmd line Oct 16, 2023
@kentquirk kentquirk added the type: configuration Changes the configuration (and therefore requires regeneration and updating of docs). label Oct 16, 2023
fchikwekwe
fchikwekwe approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@fchikwekwe fchikwekwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@kentquirk kentquirk force-pushed the kent.cmdline_availmem branch from dab9efe to 0c142cf Compare October 16, 2023 18:56
@kentquirk kentquirk merged commit fafb320 into main Oct 26, 2023
@kentquirk kentquirk deleted the kent.cmdline_availmem branch October 26, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchikwekwe fchikwekwe fchikwekwe approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees
No one assigned
Labels
type: configuration Changes the configuration (and therefore requires regeneration and updating of docs).
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.

CollectionAvailableMemory has a type mismatch between cmdenv and the refinery config
3 participants
@kentquirk @TylerHelmuth @fchikwekwe