Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Redis Auth Authentication #859

Merged
merged 4 commits into from
Oct 16, 2023
Merged

feat: Add Redis Auth Authentication #859

merged 4 commits into from
Oct 16, 2023

Conversation

tdarwin
Copy link
Contributor

@tdarwin tdarwin commented Sep 15, 2023 •
edited by kentquirk
Loading

Which problem is this PR solving?

Short description of the changes

This PR is to add the ability to use explicit AUTH strings when connecting to a Redis database. This can be done using the REFINERY_REDIS_AUTH_CODE environment variable, or the following YAML:

RedisPeerManagement:
  AuthCode: <AUTH PASSWORD STRING>

Fixes #858

@tdarwin
Add Redis Auth Authentication
03afb26 
Signed-off-by: Davin Taddeo <[email protected]>
@tdarwin tdarwin added type: enhancement New feature or request wip Work In Progress labels Sep 15, 2023
@tdarwin tdarwin changed the title feat: Add Redis Auth Authentication (WIP) feat: Add Redis Auth Authentication Sep 15, 2023
@tdarwin tdarwin marked this pull request as ready for review September 15, 2023 14:58
@tdarwin tdarwin requested a review from a team as a code owner September 15, 2023 14:58
@tdarwin tdarwin removed the wip Work In Progress label Sep 15, 2023
@kentquirk
Copy link
Contributor

Will rebase this and approve after some dependency bumps merge.

kentquirk
kentquirk approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will likely tweak this a bit, but it's a real good start. Thank you!

@kentquirk kentquirk merged commit 8d703c2 into honeycombio:main Oct 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support explicit specification of a redis AUTH string
2 participants
@tdarwin @kentquirk