Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: remove unused collect_cache metrics #1452

Merged
merged 1 commit into from
Dec 3, 2024
Merged

maint: remove unused collect_cache metrics #1452

merged 1 commit into from
Dec 3, 2024

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Dec 2, 2024

Which problem is this PR solving?

  • With the new priority queue based trace cache implementation, we no longer need to monitor cache capacity and buffer overrun

Short description of the changes

  • remove collect_cache_capacity ad collect_cache_buffer_overrun

@VinozzZ VinozzZ added the type: maintenance The necessary chores to keep the dust off. label Dec 2, 2024
@VinozzZ VinozzZ added this to the v2.9 milestone Dec 2, 2024
@VinozzZ VinozzZ self-assigned this Dec 2, 2024
@VinozzZ VinozzZ requested a review from a team as a code owner December 2, 2024 18:41
@VinozzZ VinozzZ merged commit 6755b66 into main Dec 3, 2024
7 checks passed
@VinozzZ VinozzZ deleted the yingrong/remove_cache_capacity branch December 3, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees

@VinozzZ VinozzZ

Labels
type: maintenance The necessary chores to keep the dust off.
Projects
None yet
Milestone
v2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@VinozzZ @MikeGoldsmith