feat: rename DisableTraceLocality to TraceCache #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea here a lot, but I am not so sure about the name because we have had other things about trace caches in the past and I think it's confusing. What do you think of something like |
MikeGoldsmith
approved these changes
Dec 2, 2024
kentquirk
approved these changes
Dec 2, 2024
VinozzZ
force-pushed
the
yingrong/trace_cache_config_option
branch
from
96a86bc to
43dd1a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
To improve readability of the config option for our users, this PR changes the binary trace locality feature flag to a mode structure.
Short description of the changes
DisableTraceLocalitytoTraceCachethat comes with two modes,concentratedanddistributed