Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: clean up sampler log entry #1444

Merged
merged 2 commits into from
Nov 21, 2024
Merged

maint: clean up sampler log entry #1444

merged 2 commits into from
Nov 21, 2024

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Nov 21, 2024

Which problem is this PR solving?

  • We already have a signal for cluster size change. We don't need to log this in sampler as well.

Short description of the changes

  • remove the log for cluster size change
  • change the interface assertion log to debug

@VinozzZ VinozzZ added this to the v2.9 milestone Nov 21, 2024
@VinozzZ VinozzZ self-assigned this Nov 21, 2024
@VinozzZ VinozzZ requested a review from a team as a code owner November 21, 2024 17:26
@VinozzZ VinozzZ merged commit ac659ab into main Nov 21, 2024
5 checks passed
@VinozzZ VinozzZ deleted the yingrong/cleanup_log_entry branch November 21, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees

@VinozzZ VinozzZ

Labels
None yet
Projects
None yet
Milestone
v2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@VinozzZ @kentquirk