feat: Rename EnableTraceLocality to DisableTraceLocality #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we just change the config option to Oh, it looks like you are making this change now |
MikeGoldsmith
force-pushed
the
mike/default-trace-locality-on
branch
from
5438cbe to
68e538e
Compare
MikeGoldsmith
changed the title
MikeGoldsmith
force-pushed
the
mike/default-trace-locality-on
branch
from
68e538e to
5d36fc6
Compare
|
I just made a bunch of text edits around this change. Please check them out. |
VinozzZ
force-pushed
the
mike/default-trace-locality-on
branch
from
f0e7bb7 to
efd4e33
Compare
VinozzZ
reviewed
Nov 20, 2024
There was a problem hiding this comment.
I made some changes in this PR as well. @MikeGoldsmith do u mind to give a verbal approval and then i can hit the approve button?
|
Thanks @VinozzZ - updates look good |
VinozzZ
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
To allow users to opt-in safely for disabling trace locality, we're renaming the option to disable trace locality.
Short description of the changes
EnableTraceLocalitytoDisableTraceLocality