Skip to content

Commit

Permalink
chore: Synced file(s) with honestbank/.github
Browse files Browse the repository at this point in the history
  • Loading branch information
honestbank-bot committed Jul 18, 2022
1 parent ac6d7b3 commit 3c71b52
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 7 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
continue-on-error: true
trivy_scan:
name: trivy-scan
runs-on: ubuntu-latest
steps:
- run: echo "add trivy scan" # todo
release:
name: semantic-release
runs-on: ubuntu-latest
Expand Down
18 changes: 17 additions & 1 deletion .github/workflows/semantic-pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,25 @@ on:

jobs:
main:
name: Validate PR title
name: Semantic Pull Request
runs-on: ubuntu-latest
steps:
- uses: amannn/action-semantic-pull-request@v4
name: Semantic Pull Request
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: feat - verify design doc link
run: |
if [[ "${{ github.event.pull_request.title }}" == "feat:"* ]]; then
echo "Pull request title starts with feat:";
regex='design doc: \[.+?\]\(https://www.notion.so/honestbank/.+?\)'
if [[ "${{ github.event.pull_request.body }}" =~ $regex ]]; then
echo "Pull request body contains link to a design doc 🚀";
else
echo "Pull request does not contain a design document link - please attach the relevant design doc! Refer to https://www.notion.so/honestbank/Engineering-Design-Documents-9681402a62514306876458686bfd4157";
exit 1;
fi;
else
echo "Pull request is not a feature, skipping design doc check";
fi
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@

# NUCLEAR OPTION - EXCLUDES ALL JETBRAINS IDE FILES
**/.idea/**
.idea/**

# User-specific stuff
.idea/**/workspace.xml
Expand Down Expand Up @@ -458,3 +459,6 @@ mocks
# test log file
coverage.txt
coverage.tmp

# Grafana tempo files (https://grafana.com/oss/tempo/)
**/tempo-data/**
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ repos:
- id: detect-aws-credentials
args: [ '--allow-missing-credentials' ]
- repo: https://github.com/golangci/golangci-lint
rev: v1.39.0
rev: v1.45.2
hooks:
- id: golangci-lint
- repo: https://github.com/TekWizely/pre-commit-golang
Expand Down

0 comments on commit 3c71b52

Please sign in to comment.