Add support for H8072 and H80C4 #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwp91
reviewed
Dec 8, 2024
| @@ -560,9 +562,11 @@ export default { | |||
| 'H70BC', // https://app-h5.govee.com/user-manual/wlan-guide (2024-10-15) | |||
| 'H70C1', // https://app-h5.govee.com/user-manual/wlan-guide (2024-10-15) | |||
| 'H70C2', // https://app-h5.govee.com/user-manual/wlan-guide (2024-10-15) | |||
| 'H8072', // https://app-h5.govee.com/user-manual/wlan-guide (2024-10-15) | |||
There was a problem hiding this comment.
are these two new models LAN compatible? i could not see them in the list in the wlan-guide but it sometimes gets out of date.
There was a problem hiding this comment.
Yes, both devices support LAN control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Govee RGBICWW Floor Lamps (H8072) and Govee Christmas String Lights S2 (H80C4) are not supported
💡 Proposed solution
Add H8072 and H80C4 to the RGB constants
⚙️ Release Notes
Testing
Tested changes with both models which I own and are running in my living room
Reviewer Nudging
I simply added H8072 and H80C4 in
lib/utils/contants.jsShould be a fairly simple review.