Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump reolink-aio to v0.5.13 #91550

Merged
merged 4 commits into from
Apr 22, 2023
Merged

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Apr 17, 2023

Breaking change

Proposed change

bump reolink-aio to v0.5.13:
Additions:

Fixes:

Full Changelog: starkillerOG/reolink_aio@0.5.10...0.5.13

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@starkillerOG
Copy link
Contributor Author

Could this be added to the HA 2023.4.5 milestone?

@MartinHjelmare MartinHjelmare changed the title bump reolink-aio to v0.5.13 Bump reolink-aio to v0.5.13 Apr 17, 2023
@starkillerOG
Copy link
Contributor Author

@MartinHjelmare the "Upload test coverage to Codecov" failed 2 times and the third it succeeded, lately I have had problems with the upload coverage multiple times, am I doing somthing wrong or is this a known issue?

@frenck
Copy link
Member

frenck commented Apr 18, 2023

lately I have had problems with the upload coverage multiple times, am I doing somthing wrong or is this a known issue?

codecov/codecov-action#926

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Apr 22, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @starkillerOG 👍

../Frenck

@frenck frenck added this to the 2023.4.7 milestone Apr 22, 2023
@frenck frenck merged commit 228233a into home-assistant:dev Apr 22, 2023
joanwa pushed a commit to joanwa/home-assistant that referenced this pull request Apr 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed integration: reolink Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants