Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI timeout to codecov job #90572

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Add CI timeout to codecov job #90572

merged 1 commit into from
Mar 31, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Mar 31, 2023

Proposed change

I've recently seen a couple of codecov jobs running a long time, until timeout and fail (more than an hour).
Not sure what is going on, but codecov jobs should not hold on to our runners that long.

This sets the time out to 10 minutes. If the job doesn't finish within that timeframe, something is really wrong.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Mar 31, 2023
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 31, 2023
@@ -1091,6 +1091,7 @@ jobs:
needs:
- info
- pytest
timeout-minutes: 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen it fail quite a few times recently too.

It normally takes under 10 seconds. You can probably even reduce this to 1, or maybe 2 minutes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really needed, a small hickup is fine to handle.
It just prevents it running for hours.

@frenck
Copy link
Member Author

frenck commented Mar 31, 2023

Related upstream issue codecov/codecov-action#926

@epenet epenet merged commit b24a575 into dev Mar 31, 2023
@epenet epenet deleted the frenck-2023-0650 branch March 31, 2023 10:19
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants