Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate HEOS sign_in and sign_out actions #134616

Merged
merged 5 commits into from
Jan 4, 2025
Merged

Conversation

andrewsayre
Copy link
Member

@andrewsayre andrewsayre commented Jan 4, 2025

Proposed change

Deprecates the HEOS sign_in and sign_out actions by creating an issue and logging a warning when called. Target removal for the 2025.8.0 release. These services are no longer needed now that the integration manages authentication automatically when set in the configuration options.

This change also moves the service registration into async_setup per standards so that it addresses reported issue meanwhile.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • Moved service registration into async_setup instead of async_setup_entry and removed service unload call.

  • Log warning when actions are called

  • Create issue with instructions for the user when actions called

  • This PR fixes or closes issue: fixes Heos.sign_in dont't exist, since 2024.10.3 #128691

  • This PR is related to issue:

  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @andrewsayre 👍

../Frenck

@frenck frenck merged commit f68c165 into dev Jan 4, 2025
34 checks passed
@frenck frenck deleted the heos_deprecate_actions branch January 4, 2025 23:13
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heos.sign_in dont't exist, since 2024.10.3
3 participants