Fix password type in Aussie Broadband #134612
Conversation
home-assistant
bot
added
bugfix
cla-signed
integration: aussie_broadband
small-pr
|
Hey there @nickw444, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
I do not know why CI tests are failing, pytest passes locally, and I dont understand which part of the test is failing. |
Try merging in the latest upstream changes from |
| @@ -27,7 +28,7 @@ async def async_setup_entry( | |||
| # Login to the Aussie Broadband API and retrieve the current service list | |||
| client = AussieBB( | |||
| entry.data[CONF_USERNAME], | |||
| entry.data[CONF_PASSWORD], | |||
| SecretStr(entry.data[CONF_PASSWORD]), | |||
There was a problem hiding this comment.
Ideally our code does not depend on pydantic. HA does not rely on pydantic iirc, so we should not reference them here
There was a problem hiding this comment.
Does that mean I need to fork the library and shim the init?
We can't roll back the library change because that was done in the Pydantic migration.
There was a problem hiding this comment.
Why can't we change the library?
There was a problem hiding this comment.
It's not maintained by either code owner, we can raise a PR and see what happens.
There was a problem hiding this comment.
Alternatively, could we use duck typing here?
Would just need a wrapper around the string ie:
class SecretStr:
"""Fake secret string to avoid dependency on Pydantic."""
def __init__(self, value: string):
self._value = value
def get_secret_value(self):
return self._valueThere was a problem hiding this comment.
yaleman/pyaussiebb#233 raised, if published I'll change this PR to a bump.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
Fix password type in Aussie Broadband since Pydantic migration
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: