Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flick Electric authentication #134611

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

ZephireNZ
Copy link
Contributor

@ZephireNZ ZephireNZ commented Jan 4, 2025

Proposed change

Fixes auth issue after changes introduced in #133475

I was unable to do a full end-to-end test of the changes due to lack of a login, and looks like I made a silly mistake by trying to call a method that got moved into SimpleFlickAuth in anticipation of supporting redirect-based authentication flow.

This isn't the prettiest, but it'll do the job for now 😊

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@ZephireNZ
Copy link
Contributor Author

@joostlek Hopefully this can go out with 2025.1.1? Really dumb mistake and would have caught it had I not been mocking the authentication stuff due to not having a real account to test with 🙈

@elupus
Copy link
Contributor

elupus commented Jan 4, 2025

The issue link above seem to be about tesla?

@ZephireNZ
Copy link
Contributor Author

Somehow I managed to use the wrong issue #... twice 🙃

Fixed now

@joostlek joostlek added this to the 2025.1.1 milestone Jan 4, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ZephireNZ 👍

../Frenck

@frenck frenck merged commit cc0fb80 into home-assistant:dev Jan 4, 2025
34 checks passed
@ZephireNZ ZephireNZ deleted the bugfix/flick-electric-auth branch January 5, 2025 01:42
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants