-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EnOcean support for Eltako FD62 and FL62 #134594
base: dev
Are you sure you want to change the base?
Conversation
Added new method to send a prepared packet
Added support for Eltako FL62 and FD62
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @bdurrer, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR wasn't marked as ready for review, but I will review it anyway.
This PR changes the YAML configuration, and we don't allow that anymore. Integrations first need to be migrated to a config flow.
If you need help with that, feel free to reach out on discord!
I am afraid I am not able to make this modification/change. I would guess the config flow migration is something that the enocean maintainer(s) are in the best position to do? Also note that I am using the "old" way of creating RadioPackets because I don't know how to achieve this using the new |
I am using one Eltako FD62 and one FL62 but couldn't get them to work with the stock integration.
After days of working into the Enocean protocol, trying to create suitable packets, debugging packet responses etc I got the code contained in the current pull request to work.
What is still not working are the brightness levels. For some reason, they differ if I turn on the light using the physical switch and through HA.
And if I turn on the light using HA, I cannot turn it off using the physical switch.
Otherwise this is working fine.
WARNING: I am not an experienced HA developer. This pull request definitely needs more work and better integration. It's meant as a proof-of-concept for the above Eltako devices and hopefully helpful for others with the same devices.