-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vesync support for debug mode in library #134571
base: dev
Are you sure you want to change the base?
Conversation
Hey there @markperdue, @webdjoe, @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
That will work but it requires restarting the integration. Can we list to the event EVENT_LOGGING_CHANGED like |
That's indeed a good point, we should be able to change it on runtime for the best experience. Why do we actually overwrite this in the lib as opposed to just logging in debug? |
Good question, I'm not sure why the library over writes it. @webdjoe thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a merge conflict
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Fixed. |
Proposed change
Previously debug mode for the logger didn't pass to pyvesync library. The library overrides the settings back to default. Instead it has a flag you can pass in. This takes the debug mode setting and passes to the library allowing the standard debug functions to work. It also has listeners to adjust this on the fly.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: