Matter TemperatureLevel feature from TemperatureControl cluster #134532
+1,636
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
has-tests
integration: matter
Quality Scale: No score
labels
|
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
19 tasks
marcelveldt
reviewed
Jan 16, 2025
| @@ -111,6 +111,35 @@ def _update_from_device(self) -> None: | |||
| self._attr_name = desc | |||
|
|
|||
|
|
|||
| class MatterLevelSelectEntity(MatterSelectEntity): | |||
There was a problem hiding this comment.
I think we can further generalize this one.
In essence its executing a command with a value.
So we can have a schema that takes the command
There was a problem hiding this comment.
I haven't figured out how to make the command argument generic. When the command is called, the variable name is used, not its value.
Do you have a suggestion?
Error: homeassistant/components/matter/select.py:130: error: Unexpected keyword argument "targetTemperatureLevel" [call-arg] Error: homeassistant/components/matter/select.py:130: error: "None" not callable [misc]
marcelveldt
reviewed
Jan 21, 2025
Comment on lines
+62
to
+66
| @property | ||
| def secondary_attribute(self) -> type[ClusterAttributeDescriptor]: | ||
| """Return Secondary Attribute belonging to the entity.""" | ||
| return self.attributes_to_watch[1] | ||
|
|
There was a problem hiding this comment.
this is dangerous - lets not do this
marcelveldt
reviewed
Jan 21, 2025
Comment on lines
+139
to
+141
| select_list = self.get_matter_attribute_value( | ||
| self._entity_info.secondary_attribute | ||
| ) |
There was a problem hiding this comment.
please use a local attribute here to get the SupportedTemperatureLevels attribute value
marcelveldt
reviewed
Jan 21, 2025
| key="TemperatureControlSelectedTemperatureLevel", | ||
| translation_key="temperature_level", | ||
| command=clusters.TemperatureControl.Commands.SetTemperature, | ||
| # field=clusters.TemperatureControl.Commands.SetTemperature.targetTemperatureLevel, |
marcelveldt
reviewed
Jan 21, 2025
| """Change the selected option.""" | ||
| # select the ID from the label string | ||
| option_id = self._attr_options.index(option) | ||
| # field = self.entity_description.field |
marcelveldt
reviewed
Jan 21, 2025
| @@ -46,6 +47,9 @@ async def async_setup_entry( | |||
| class MatterSelectEntityDescription(SelectEntityDescription, MatterEntityDescription): | |||
| """Describe Matter select entities.""" | |||
|
|
|||
| command: Callable[[], Any] | None = None | |||
| field: str | None = None | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add support for
TemperatureLevelfeature from Matter Temperature Control Cluster (0x0056) used in the following device types:You can select the Temperature Level from a select list.
TemperatureLevel feature:
For devices that use vendor-specific temperature levels for the temperature setpoint, such as some washers (Dishwasher, LaundryDryer, LaundryWasher)
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: