Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pip_kwargs consistent with async_mount_local_lib_path #134530

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ruifung
Copy link

@ruifung ruifung commented Jan 3, 2025

Breaking change

Proposed change

The existing requirements.pip_kwargs function, seems like it intended, under specific circumstances (not virtualenv and not docker, so CORE installations?), to install additional dependencies into the directory mounted by bootstrap.async_mount_local_lib_path (/config/deps/..).

However, what actually ends up happening is that pip_kwargs sets target=/config/deps while async_mount_local_lib_path mounts /config/deps/python3.13/site-packages into sys.path.

This results in HASS installing packages into a directory it doesn't mount onto sys.path.
Therefore, this PR is to correct that inconsistency by making pip_kwargs determine the target in the same way async_mount_local_lib_path does, ensuring that it will install additional dependencies into the same location it mounts.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Jan 3, 2025
@ruifung ruifung force-pushed the fix-deps-install-path branch from b1d8077 to f71cb95 Compare January 3, 2025 10:34
@ruifung ruifung marked this pull request as ready for review January 3, 2025 10:36
@ruifung ruifung requested a review from a team as a code owner January 3, 2025 10:36
@ruifung ruifung force-pushed the fix-deps-install-path branch from f71cb95 to ef5b56b Compare January 3, 2025 10:37
@ruifung ruifung marked this pull request as draft January 3, 2025 10:41
@ruifung ruifung force-pushed the fix-deps-install-path branch from ef5b56b to fe4f201 Compare January 3, 2025 10:41
@ruifung ruifung marked this pull request as ready for review January 3, 2025 10:43
@ruifung ruifung force-pushed the fix-deps-install-path branch from fe4f201 to 2f9c883 Compare January 5, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant