Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Resideo First Alert Integration in Lyric Integration #134509

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

donavanbecker
Copy link

@donavanbecker donavanbecker commented Jan 3, 2025

Breaking change

Proposed change

Add support for First Alert App users in the Resideo ecosystem (Lyric)
https://developer.honeywellhome.com/content/first-alert-app-integration-guide

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@donavanbecker donavanbecker requested a review from a team as a code owner January 3, 2025 04:51
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @donavanbecker

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot added cla-needed core new-feature small-pr PRs with less than 30 lines. labels Jan 3, 2025
@home-assistant
Copy link

home-assistant bot commented Jan 3, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 3, 2025 04:51
@donavanbecker donavanbecker marked this pull request as ready for review January 3, 2025 05:01
@@ -167,6 +167,7 @@ async def async_generate_authorize_url(self, flow_id: str) -> str:
URL(self.authorize_url)
.with_query(
{
"appSelect": 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integrations should implement extra_authorize_data if more query parameters to the authorize url are needed.

@home-assistant home-assistant bot marked this pull request as draft January 3, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants