-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Z-wave climate sensor override for Heatit Z-TRM6 #103896
Add Z-wave climate sensor override for Heatit Z-TRM6 #103896
Conversation
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Martin Hjelmare <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Side note for future PRs: Please retain the whole PR description template, also the parts that are not applicable, like breaking change section etc. Leave the parts that aren't applicable empty.
Proposed change
This PR adds support for the z-trm6 z-wave thermostat.
The thermostat supports multiple operation modes and as such it supports 3 temp sensors depending on the config, the pr swaps the climate entity to support show the correct sensor.
Type of change
Additional information
The code is done in the same style as z-trm3 + 2, but a better approch might be to don't rely on the template names (that could be changed upstream) and rather the integer value of the config param.
See comment here: zwave-js/node-zwave-js#6464 (review)
But this PR is made in the style of the previous code changes.
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: