Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calendar): improve responsive styles #2538

Merged
merged 3 commits into from
Mar 8, 2025
Merged

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Mar 8, 2025


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Before
image

After
Screenshot 2025-03-08 181118

Improved dropdown
The dropdown now has the same amount of padding on all sides
Screenshot 2025-03-08 181126

Fixed overhang of dropdown
Screenshot_20250308_181107_com.android.chrome.jpg

Part of #2531
Closes #2064

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Mar 8, 2025
@Meierschlumpf Meierschlumpf self-assigned this Mar 8, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner March 8, 2025 17:17
Copy link

deepsource-io bot commented Mar 8, 2025

Here's the code health analysis summary for commits ac5fc38..d95b14a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Mar 8, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.28% 9903 / 42538
🔵 Statements 23.28% 9903 / 42538
🔵 Functions 30.05% 415 / 1381
🔵 Branches 64.95% 1186 / 1826
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/widgets/src/calendar/calendar-event-list.tsx 0% 0% 0% 0% 1-121
packages/widgets/src/calendar/calender-day.tsx 0% 0% 0% 0% 1-90
packages/widgets/src/calendar/component.tsx 0% 0% 0% 0% 1-139
Generated in workflow #5434 for commit d95b14a by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf merged commit 1db9c3c into dev Mar 8, 2025
10 of 18 checks passed
@Meierschlumpf Meierschlumpf deleted the calendar-improve-styles branch March 8, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Mobile board calendar widget pop up overhang
2 participants