Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bookmarks): improve responsive styles #2536

Merged
merged 2 commits into from
Mar 8, 2025

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Before
Screenshot 2025-03-08 135725

After
Screenshot 2025-03-08 135632

New options
Screenshot 2025-03-08 135838

Difference between grid (right) and gridHorizontal (left)
Screenshot 2025-03-08 140131

Part of #2531

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Mar 8, 2025
@Meierschlumpf Meierschlumpf self-assigned this Mar 8, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner March 8, 2025 13:07
Copy link

deepsource-io bot commented Mar 8, 2025

Here's the code health analysis summary for commits ac5fc38..88bc1ba. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Mar 8, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.26% 9905 / 42568
🔵 Statements 23.26% 9905 / 42568
🔵 Functions 30.02% 415 / 1382
🔵 Branches 64.95% 1186 / 1826
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/old-import/src/widgets/options.ts 73.12% 100% 0% 73.12% 33-40, 65, 67, 70, 73, 140-142, 144-146, 149-151, 154, 170-192
packages/widgets/src/bookmarks/component.tsx 0% 0% 0% 0% 1-290
packages/widgets/src/bookmarks/index.tsx 53.06% 100% 20% 53.06% 29-47, 51-58
Generated in workflow #5432 for commit 88bc1ba by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf merged commit df249a0 into dev Mar 8, 2025
13 checks passed
@Meierschlumpf Meierschlumpf deleted the bookmarks-improve-styles branch March 8, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants