Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pi-hole): wrong fetch used in factory #2527

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Mar 7, 2025
@Meierschlumpf Meierschlumpf self-assigned this Mar 7, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner March 7, 2025 14:40
Copy link

github-actions bot commented Mar 7, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.3% 9898 / 42471
🔵 Statements 23.3% 9898 / 42471
🔵 Functions 30.15% 415 / 1376
🔵 Branches 65.05% 1186 / 1823
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/integrations/src/pi-hole/pi-hole-integration-factory.ts 20% 100% 0% 20% 9-23
Generated in workflow #5412 for commit 36e7b4e by the Vitest Coverage Report Action

Copy link

deepsource-io bot commented Mar 7, 2025

Here's the code health analysis summary for commits a572aae..36e7b4e. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Meierschlumpf Meierschlumpf merged commit 9881577 into dev Mar 7, 2025
18 of 19 checks passed
@Meierschlumpf Meierschlumpf deleted the fix-fetch-without-custom-certificates branch March 7, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants