Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove cqmin system #2407

Merged
merged 2 commits into from
Mar 7, 2025
Merged

feat: remove cqmin system #2407

merged 2 commits into from
Mar 7, 2025

Conversation

manuel-rw
Copy link
Member

@manuel-rw manuel-rw commented Feb 23, 2025


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Todo:

  • Fix the light mode
  • Fix opacity on newly colored elements

Before

image
image

After

image
image
image
image

Closes #2109
Closes #2072

@manuel-rw manuel-rw self-assigned this Feb 23, 2025
@manuel-rw manuel-rw force-pushed the feat/remove-cqmin-system branch from 575c09f to 133ae86 Compare February 23, 2025 15:23
Copy link

deepsource-io bot commented Feb 23, 2025

Here's the code health analysis summary for commits 3403579..f9618e4. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Feb 23, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.32% 9898 / 42436
🔵 Statements 23.32% 9898 / 42436
🔵 Functions 30.09% 415 / 1379
🔵 Branches 64.95% 1186 / 1826
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/widgets/src/app/component.tsx 0% 0% 0% 0% 1-125
packages/widgets/src/app/ping/ping-dot.tsx 0% 0% 0% 0% 1-34
packages/widgets/src/bookmarks/component.tsx 0% 0% 0% 0% 1-257
packages/widgets/src/calendar/calender-day.tsx 0% 0% 0% 0% 1-86
packages/widgets/src/calendar/component.tsx 0% 0% 0% 0% 1-139
packages/widgets/src/clock/component.tsx 0% 0% 0% 0% 1-77
packages/widgets/src/dns-hole/controls/component.tsx 0% 0% 0% 0% 1-396
packages/widgets/src/dns-hole/summary/component.tsx 0% 0% 0% 0% 1-223
packages/widgets/src/downloads/component.tsx 0% 0% 0% 0% 1-975
packages/widgets/src/health-monitoring/system-health.tsx 0% 0% 0% 0% 1-304
packages/widgets/src/health-monitoring/rings/cpu-ring.tsx 0% 0% 0% 0% 1-33
packages/widgets/src/health-monitoring/rings/cpu-temp-ring.tsx 0% 0% 0% 0% 1-39
packages/widgets/src/health-monitoring/rings/memory-ring.tsx 0% 0% 0% 0% 1-54
packages/widgets/src/indexer-manager/component.tsx 0% 0% 0% 0% 1-112
packages/widgets/src/media-requests/list/component.tsx 0% 0% 0% 0% 1-246
packages/widgets/src/media-requests/stats/component.tsx 0% 0% 0% 0% 1-184
packages/widgets/src/media-server/component.tsx 0% 0% 0% 0% 1-251
packages/widgets/src/minecraft/server-status/component.tsx 0% 0% 0% 0% 1-62
packages/widgets/src/notebook/notebook.tsx 0% 0% 0% 0% 1-899
packages/widgets/src/rssFeed/component.tsx 0% 0% 0% 0% 1-78
packages/widgets/src/weather/component.tsx 0% 0% 0% 0% 1-210
Generated in workflow #5416 for commit f9618e4 by the Vitest Coverage Report Action

@manuel-rw manuel-rw force-pushed the feat/remove-cqmin-system branch 15 times, most recently from e2c120e to 66901fb Compare February 27, 2025 20:31
@manuel-rw manuel-rw added the enhancement New feature or request label Feb 27, 2025
@manuel-rw manuel-rw marked this pull request as ready for review February 27, 2025 20:31
@manuel-rw manuel-rw requested a review from a team as a code owner February 27, 2025 20:31
@manuel-rw manuel-rw force-pushed the feat/remove-cqmin-system branch 3 times, most recently from 85e26e1 to 0040e2a Compare March 1, 2025 16:58
@manuel-rw manuel-rw requested a review from Meierschlumpf March 1, 2025 16:58
Meierschlumpf
Meierschlumpf previously approved these changes Mar 1, 2025
@Meierschlumpf Meierschlumpf self-requested a review March 1, 2025 21:52
@manuel-rw manuel-rw force-pushed the feat/remove-cqmin-system branch 6 times, most recently from 5a42158 to 0c2a7a8 Compare March 5, 2025 21:18
@manuel-rw manuel-rw force-pushed the feat/remove-cqmin-system branch from 0c2a7a8 to 90cf0ef Compare March 6, 2025 20:08
@Meierschlumpf Meierschlumpf self-requested a review March 7, 2025 14:39
@Meierschlumpf
Copy link
Member

Meierschlumpf commented Mar 7, 2025

I think the weather widget texts should stay the same size independent of the widget size, otherwise we get this:

Bildschirmaufnahme.2025-03-07.162519.mp4

@Meierschlumpf
Copy link
Member

Meierschlumpf commented Mar 7, 2025

What do you think?

image

You can find the changes I made here:
1205fbe

@Meierschlumpf
Copy link
Member

Beside that looks good to me 👍🏼

@Meierschlumpf
Copy link
Member

Meierschlumpf commented Mar 7, 2025

Changes for weather approved by @manuel-rw

@Meierschlumpf Meierschlumpf merged commit 37d4714 into dev Mar 7, 2025
13 checks passed
@Meierschlumpf Meierschlumpf deleted the feat/remove-cqmin-system branch March 7, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: bookmarks section pt2 bug: font size on tabs title and some integration
2 participants