-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: docker widget #2288
base: dev
Are you sure you want to change the base?
feat: docker widget #2288
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
Coverage Report
File Coverage
|
I will remove unused variables |
Hi @hillaliy , thanks for the contribution. Please see the lint and DeepSource first. After that, we'll happily review your PR. Thanks! |
Lint and deepSource errors is because unused variables. I'm still thinking if need to add options so if you can review my PR and if you have an idea for widget options. Thanks |
Co-authored-by: Crowdin Homarr <190541745+homarr-crowdin[bot]@users.noreply.github.com>
Co-authored-by: homarr-renovate[bot] <158783068+homarr-renovate[bot]@users.noreply.github.com>
@Meierschlumpf I need your help with this widget. Refresh rate is not good enough. |
|
I mean with data refresh. Can you pull it and try it? |
Okay yeah currently it is cached for 5 minutes: const dockerCache = createCacheChannel<{
containers: (ContainerInfo & { instance: string; iconUrl: string | null; cpuUsage: number; memoryUsage: number })[];
}>("docker-containers", 5 * 60 * 1000); I would suggest that we replace this with the request-handlers we use for other integrations as well. Then we can also add a subscription functionallity |
@hillaliy i think for this use case we'd want the data to be refreshed after the page loads as well as after every action (start/stop/restart) |
It's the widget and not a modal or something, so we want to refresh the data every few seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also there should be a background job that periodically updates the data (like every minute) and we need to decide who should be able to add this widget to a board. The interactions should be restricted to only admins I would guess.
The cqmin system was just removed, so please adjust that as well
Homarr
Thank you for your contribution. Please ensure that your pull request meets the following pull request:
pnpm buid
, autofix withpnpm format:fix
)dev
branchx
,y
,i
or any abbrevation)