Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add stack and cause to trpc error logging #2033

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

I'll suggest that we add this as it allows more informative log messages that also allow us to know why the fetch failed for example #2017

@Meierschlumpf Meierschlumpf self-assigned this Jan 20, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner January 20, 2025 18:11
Copy link

deepsource-io bot commented Jan 20, 2025

Here's the code health analysis summary for commits 55feb9d..c3b5376. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.05% 8268 / 39269
🔵 Statements 21.05% 8268 / 39269
🔵 Functions 25.12% 306 / 1218
🔵 Branches 61.76% 908 / 1470
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/src/app/api/trpc/[trpc]/route.ts 0% 0% 0% 0% 1-43
Generated in workflow #4692 for commit c3b5376 by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf merged commit e47d497 into dev Jan 21, 2025
13 checks passed
@Meierschlumpf Meierschlumpf deleted the better-trpc-errors branch January 21, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant