Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript typings #2

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Add TypeScript typings #2

merged 6 commits into from
Jan 6, 2025

Conversation

yassernasc
Copy link
Contributor

No description provided.

kasperisager
kasperisager requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@kasperisager kasperisager left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All callback arguments should be declared using their corresponding signature, e.g. (err: Error) => void.

kasperisager
kasperisager requested changes Jan 6, 2025
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
kasperisager
kasperisager requested changes Jan 6, 2025
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
kasperisager
kasperisager requested changes Jan 6, 2025
View reviewed changes
package.json Outdated Show resolved Hide resolved
@yassernasc yassernasc merged commit 973972b into main Jan 6, 2025
3 checks passed
@yassernasc yassernasc deleted the typings branch January 6, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperisager kasperisager kasperisager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yassernasc @kasperisager