Development #1
Open
Development #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daymon4
reviewed
Oct 16, 2019
Comment on lines
+31
to
+46
| const getTriangleOne = size => { | ||
| let str = ''; | ||
|
|
||
| for (let i = size; i > 0; i--) { | ||
| for (let j = 0; j < size + 1; j++) { | ||
| if (j >= i) { | ||
| str += '*'; | ||
| } else { | ||
| str += ' '; | ||
| } | ||
| } | ||
| str += '\n'; | ||
| } | ||
|
|
||
| console.log(str); | ||
| } |
There was a problem hiding this comment.
Other variant:
const getTriangleOne = size => {
let str = '';
for (let i =0; i < size; i++) {
for (let j = 0; j < size; j++) {
if (j >= size - 1 - i) {
str += '*';
} else {
str += ' ';
}
}
str += '\n';
}
console.log(str);
}
|
|
||
| for (let i = 0; i < size; i++) { | ||
| for (let j = 0; j < size; j++) { | ||
| if (i <= j) { |
Comment on lines
+82
to
+97
| const getTriangleFour = size => { | ||
| let str = ''; | ||
|
|
||
| for (let i = size; i > 0; i--) { | ||
| for (let j = 0; j < size + 1; j++) { | ||
| if (i > j) { | ||
| str += '*'; | ||
| } else { | ||
| str += ' '; | ||
| } | ||
| } | ||
| str += '\n'; | ||
| } | ||
|
|
||
| console.log(str); | ||
| } |
There was a problem hiding this comment.
Other variant:
const getTriangleFour = size => {
let str = '';
for (let i = 0; i < size; i++) {
for (let j = 0; j < size; j++) {
if (j <= size - 1 - i) {
str += '*';
} else {
str += ' ';
}
}
str += '\n';
}
console.log(str);
}
Comment on lines
+102
to
+104
| for (let i = 0; i < size; i++) { | ||
| for (let j = size; 0 < j; j--) { | ||
| if (j - 1 === i || j === 1 || i === size - 1) { |
There was a problem hiding this comment.
for (let i = 0; i < size; i++) {
for (let j = 0; j < size; j++) {
if (i === size - 1 || j === size - 1 || j === size - 1 - i) {
Comment on lines
+153
to
+155
| for (let i = 0; i < size; i++) { | ||
| for (let j = size; 0 < j; j--) { | ||
| if (j - 1 === i || i === 0 || j === size) { |
There was a problem hiding this comment.
for (let i = 0; i < size; i++) {
for (let j = 0; j < size; j++) {
if (i === 0 || j === 0 || i === size - 1 - j) {
|
|
||
| for (let i = 0; i < size; i++) { | ||
| for (let j = 0; j < size; j++) { | ||
| if (j === i || i === size - j - 1) { |
|
|
||
| for (let i = 0; i < size; i++) { | ||
| for (let j = 0; j < size; j++) { | ||
| if (j === i || i === size - j - 1 || i === 0 || i === size - 1) { |
|
|
||
| for (let i = 0; i < size; i++) { | ||
| for (let j = 0; j < size; j++) { | ||
| if ((j < i) && (i >= size - j) || (j > i) && (j < size - i) || j === i || i === size - 1 || i === size - j - 1) { |
There was a problem hiding this comment.
if (j >= i && j <= size - 1 - i || j >= size - 1 - i && j <= i) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.