Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase two redo #167

Draft
wants to merge 152 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
152 commits
Select commit Hold shift + click to select a range
302a0d5
lots of little changes to test blocks for phase 1b
DanCollinz Sep 26, 2023
d8e0265
expanding hero
DanCollinz Sep 26, 2023
2b0c697
fixing icons
DanCollinz Sep 26, 2023
7572960
Updating sections and cards
DanCollinz Sep 27, 2023
931b627
latest changes adding toc, and changing card styles
DanCollinz Oct 18, 2023
8e9c204
form demo set up
DanCollinz Oct 18, 2023
71757a2
Update README.md
DanCollinz Oct 18, 2023
8a01265
updates from display changes for phase 1b
DanCollinz Oct 30, 2023
3651ed4
lots of lint changes
DanCollinz Nov 6, 2023
47a48e3
matching designs for these images to the designs
DanCollinz Dec 1, 2023
e5bb5da
adding Sagar's changes
DanCollinz Jan 19, 2024
b2697ab
updating footer and align section headings center
DanCollinz Jan 19, 2024
b93a7be
removing whitespace in padding
DanCollinz Jan 19, 2024
6ad12d1
Update styles.css
DanCollinz Jan 19, 2024
6b15ed4
resize heros, temp
DanCollinz Jan 19, 2024
34d4b2c
adding space between sections
DanCollinz Jan 19, 2024
b17219c
center align content section titles
DanCollinz Jan 22, 2024
4f26d1e
for free trial cards added a border
DanCollinz Jan 22, 2024
849e370
Update cards.css
DanCollinz Jan 22, 2024
0c698ca
issue 155 update style for floating image block
DanCollinz Jan 23, 2024
41e0bc3
Floating image tune up and such
DanCollinz Jan 24, 2024
0967b78
fixed few lint issues and adjusted disclaimer postion
rrrragas Jan 25, 2024
5dabf2d
added adoibe launch library for testing
DanCollinz Jan 29, 2024
f84d5b2
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
DanCollinz Jan 29, 2024
879b147
changing launch link
DanCollinz Jan 29, 2024
62ac9d4
updated styles for product card
rrrragas Jan 30, 2024
7d93de7
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
rrrragas Jan 30, 2024
70eaf4d
adding launch link for new environment
DanCollinz Jan 30, 2024
3fb2eb1
removing script tag
DanCollinz Jan 30, 2024
e3662d8
updated code for header block as per new design
rrrragas Feb 6, 2024
883fb3d
fixes for eslint errors
rrrragas Feb 6, 2024
519931e
fix for few eslint issues
rrrragas Feb 6, 2024
47be512
updated styles for footer new design
rrrragas Feb 7, 2024
b1abe8f
updated background
rrrragas Feb 7, 2024
d996857
icon card tweaks
DanCollinz Feb 7, 2024
308dae1
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
DanCollinz Feb 7, 2024
74b8547
adding new launch env
DanCollinz Feb 7, 2024
437f70f
added new launch env
DanCollinz Feb 7, 2024
e8979c5
updating launch code and adding assets library
DanCollinz Feb 7, 2024
84faf87
https://github.com/hlxsites/takeda-ihs/issues/169
DanCollinz Feb 8, 2024
6924d1f
bunch of floating image content container tweaks
DanCollinz Feb 8, 2024
7adcc90
updated styles for footer links alignment
rrrragas Feb 8, 2024
ac7406a
removing GA
DanCollinz Feb 9, 2024
f8e48cb
remove gtm
DanCollinz Feb 9, 2024
4e740d7
remove const GTM
DanCollinz Feb 9, 2024
f5f274b
more gtm errors
DanCollinz Feb 9, 2024
1a092a2
nav tune up, space above and space between lis
DanCollinz Feb 9, 2024
b266954
top nav style changes as per new designs
rrrragas Feb 13, 2024
94e196f
trying to add gotham font
DanCollinz Feb 13, 2024
2c35ea1
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
DanCollinz Feb 13, 2024
272e025
Updated form block (#170)
gargadobe Feb 13, 2024
eb4d9bf
bug fix
gargadobe Feb 14, 2024
0d1e435
required field constraint message
gargadobe Feb 14, 2024
b105322
styles for subnav dropdown
rrrragas Feb 15, 2024
d724dcd
null check for subnav dropdown
rrrragas Feb 15, 2024
135cbad
null check for subnav dropdown
rrrragas Feb 15, 2024
0ada7b4
checkbox bug fix
gargadobe Feb 15, 2024
f4a1139
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
DanCollinz Feb 15, 2024
7a1086c
adding fonts
DanCollinz Feb 15, 2024
30ffcf7
fragment support
gargadobe Feb 15, 2024
8fab7c9
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
gargadobe Feb 15, 2024
9aca845
hero placement and dimension changes
DanCollinz Feb 15, 2024
8c94a24
update hero content container
DanCollinz Feb 15, 2024
cc2efbc
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
DanCollinz Feb 15, 2024
047a288
position hero image
DanCollinz Feb 15, 2024
359ec31
modal code
gargadobe Feb 16, 2024
05e1b5b
lib-franklin updated
gargadobe Feb 16, 2024
157bdd1
added Goutham fonts
rrrragas Feb 16, 2024
2630f31
few default fonts for Goutham
rrrragas Feb 16, 2024
895c511
updated footer fonts
rrrragas Feb 16, 2024
2ec9877
Merge branch 'phase-two-redo' into submit-modal
gargadobe Feb 19, 2024
b4c556f
Merge branch 'main' of https://github.com/hlxsites/takeda-ihs into su…
gargadobe Feb 19, 2024
bceab2b
Merge branch 'submit-modal' of https://github.com/hlxsites/takeda-ihs…
gargadobe Feb 19, 2024
a77f3fb
Submit modal (#171)
gargadobe Feb 19, 2024
97e3c55
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
rrrragas Feb 19, 2024
55733fa
updated error styles
rrrragas Feb 19, 2024
854ef01
removed padding top on first child of main
rrrragas Feb 19, 2024
5cf56dd
made default content wrapper to display block
rrrragas Feb 19, 2024
14eb8de
form tune up
DanCollinz Feb 19, 2024
3527afb
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
DanCollinz Feb 19, 2024
54323d6
form tune up
DanCollinz Feb 19, 2024
0311d99
fixing form button
DanCollinz Feb 19, 2024
448facb
removed duplicate icons decorations
rrrragas Feb 20, 2024
e69954b
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
rrrragas Feb 20, 2024
b42fa3a
updated checkbox and button color
rrrragas Feb 20, 2024
22cb665
pattern error message
gargadobe Feb 20, 2024
23c4fe5
placeholder bug fix
gargadobe Feb 20, 2024
8712c39
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
DanCollinz Feb 20, 2024
a16301a
hero placement and form element borders
DanCollinz Feb 20, 2024
65ff52e
cards section tune up
DanCollinz Feb 20, 2024
96ebace
adding hero class for h1
DanCollinz Feb 20, 2024
246c15f
update more specific ref to section hero h1
DanCollinz Feb 20, 2024
6024834
updated style for cards-4
rrrragas Feb 20, 2024
442bb7d
adding rule for first child p of card section
DanCollinz Feb 20, 2024
fc93745
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
DanCollinz Feb 20, 2024
f5b4ba1
corrected color for section heading
DanCollinz Feb 20, 2024
d3d6cc0
adding class for all section headings
DanCollinz Feb 20, 2024
5c3a0cc
multi value separator change
gargadobe Feb 20, 2024
6218785
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
DanCollinz Feb 20, 2024
dd417e9
adding another class for plain section containers
DanCollinz Feb 20, 2024
3ed663d
checkbox styling fix
gargadobe Feb 20, 2024
a116243
submit button styling
gargadobe Feb 20, 2024
0b31b88
used id instead of data-id to identify sections
rrrragas Feb 21, 2024
68fe801
updated intersectioratio
rrrragas Feb 21, 2024
4b12721
adding gap to sub nav items
DanCollinz Feb 21, 2024
f574fee
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
DanCollinz Feb 21, 2024
b14d16b
adding icons
DanCollinz Feb 21, 2024
35c5b5e
more icons
DanCollinz Feb 21, 2024
8f0cb52
setting product cards to stack one over the other
DanCollinz Feb 21, 2024
34a20ce
adding new icon jump_link and css to support it
DanCollinz Feb 21, 2024
1d54497
more product card tweaks
DanCollinz Feb 21, 2024
aabf89a
headlines in flooating image blocks need to be red
DanCollinz Feb 21, 2024
a41df25
align sub nav elements to center
DanCollinz Feb 21, 2024
a44168d
general hero header footer tune up
DanCollinz Feb 21, 2024
e363d22
more layout updates
DanCollinz Feb 21, 2024
329a854
form layout changes
DanCollinz Feb 21, 2024
1b00594
Revert "align sub nav elements to center"
DanCollinz Feb 21, 2024
c39a190
Revert "Revert "align sub nav elements to center""
DanCollinz Feb 21, 2024
8a75a8c
fix hero image I broke
DanCollinz Feb 21, 2024
24add42
more layout updates
DanCollinz Feb 21, 2024
c7b408c
setting grey background to width of viewport
DanCollinz Feb 22, 2024
d05efed
tiger stripe, grey to white to alternate cards
DanCollinz Feb 22, 2024
2b90424
deciding current section based on the visibility
rrrragas Feb 22, 2024
fdc3903
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
rrrragas Feb 22, 2024
8af0a44
updated code most visible section
rrrragas Feb 22, 2024
e82ee65
adding icons for nav and positioning close and hamburger icon
DanCollinz Feb 22, 2024
df78c15
Merge branch 'phase-two-redo' of https://github.com/hlxsites/takeda-i…
DanCollinz Feb 22, 2024
a9879de
hero tune up
DanCollinz Feb 22, 2024
1e708b1
adjusting content bump for pages with and without default hero
DanCollinz Feb 22, 2024
17f4f9b
update forms and nav and header
DanCollinz Feb 22, 2024
f47c344
adding hover state colors
DanCollinz Feb 22, 2024
800ff89
card alignment padding etc
DanCollinz Feb 23, 2024
e16275f
more card alignment
DanCollinz Feb 23, 2024
835e92e
adding hover states to nav
DanCollinz Feb 23, 2024
b7a31c9
force button to bottom of cards
DanCollinz Feb 23, 2024
8b46a52
content align changes and mobile down arrow fix
DanCollinz Feb 25, 2024
a9ad2a5
assorted hero changes
DanCollinz Feb 26, 2024
e203495
redo for product cards
DanCollinz Feb 27, 2024
9b13dbb
general style system alignment
DanCollinz Feb 28, 2024
4d14421
more formating
DanCollinz Feb 28, 2024
5b9e98f
qdading class to nav button and chaging rotaion on mobile nav open icon
DanCollinz Mar 5, 2024
2a7278b
adding transition to buttons and hover states to links
DanCollinz Mar 5, 2024
13f4a85
h3 foont weight should be bold
DanCollinz Mar 5, 2024
0ea284e
adding sitemap.yaml file
DanCollinz Mar 5, 2024
c2a8777
update sitemap name
DanCollinz Mar 5, 2024
dbedb6c
adding robots file and adding new launch tag
DanCollinz Mar 7, 2024
6381102
removing hover color for li
DanCollinz Mar 21, 2024
b4782b8
adding hover states to nav and nav ribbon
DanCollinz Mar 21, 2024
6e58b3b
styles for modal and hide hidden fields
DanCollinz May 20, 2024
694df1f
Moving description above check boxes
DanCollinz May 28, 2024
a1e04b0
forgot to remove the append line, description shows above and below
DanCollinz May 28, 2024
d3efd51
adding a block library
DanCollinz May 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 404.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<meta property="og:title" content="Page not found">
<script src="/scripts/scripts.js" type="module" crossorigin="use-credentials"></script>
<script type="module">
import { sampleRUM } from '/scripts/lib-franklin.js';
import { sampleRUM } from '/scripts/aem.js';

window.addEventListener('load', () => {
if (document.referrer) {
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ Takeda Integrated Health Systems

## Environments

-Preview: https://main--takeda-ihs--hlxsites.hlx.page/
-Preview: https://phase-two-redo--takeda-ihs--hlxsites.hlx.page/

-Live: https://main--takeda-ihs--hlxsites.hlx.live/
-Live: https://phase-two-redo--takeda-ihs--hlxsites.hlx.live/

## Installation

Expand Down
3 changes: 3 additions & 0 deletions arrow-right.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion blocks/brightcove/brightcove.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { readBlockConfig } from '../../scripts/lib-franklin.js';
import { readBlockConfig } from '../../scripts/aem.js';

export default async function decorate(block) {
const config = readBlockConfig(block);
Expand Down
2 changes: 1 addition & 1 deletion blocks/calendar-events/calendar-events.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { decorateIcons } from '../../scripts/lib-franklin.js';
import { decorateIcons } from '../../scripts/aem.js';

export default async function decorate(block) {
block.classList.add(`calendar-events-${block.children.length}`);
Expand Down
6 changes: 5 additions & 1 deletion blocks/cards/cards.css
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@
gap: 1.75em;
}


.cards.default.block > div {
padding: 20px 16px;
border-radius: 10px;
border-radius: 8px;
box-shadow: 0 4px 10px 0 rgba(0 0 0 / 20%);
background-color: rgba(255 255 255 / 66%);
}

Expand Down Expand Up @@ -49,6 +51,8 @@
@media screen and (min-width: 600px) {
.cards.default.block > div {
padding: 20px 32px;
border-radius: 8px;
box-shadow: 0 4px 10px 0 rgba(0 0 0 / 20%);
}
}

Expand Down
113 changes: 80 additions & 33 deletions blocks/cards/cta.css
Original file line number Diff line number Diff line change
Expand Up @@ -3,65 +3,96 @@
gap: 1em;
}

.cards.cta.block > ul > li {
display: block;
padding: 16px;
border-radius: 8px;
.cards.cta.block>ul>li {
display: flex;
padding: 24px;
box-shadow: 0 4px 10px 0 rgba(0 0 0 / 20%);
background-color: #fff;
justify-content: center;
position:relative ;
}

.cards.cta.block > ul > li div {
padding-top: 30px;
.cards.cta.block>ul>li div {
padding-top: 0;
border-top: 3px solid white;
}

.cards.cta.block > ul > li.onepath div {
border-color: var(--onepath);
.cards.cta.block>ul>li.onepath div {
/* border-color: var(--onepath); */
}

.cards.cta.block>ul>li.myigsource div {
/* border-color: var(--myigsource); */
}

.cards.cta.block>ul>li.hello-programs div {
/* border-color: var(--hello-programs); */
}

.cards.cta.block button.primary.top-link {
display: inline-block;
padding: 0;
font-weight: bold;
line-height: var(--line-height-l);
text-decoration: none;
border: 0;
}

.cards.cta.block > ul > li.myigsource div {
border-color: var(--myigsource);
.cards.cta.block .card-body .top-section {
position: relative;
margin-left: 12px;
}

.cards.cta.block .card-body p.link-container span.icon svg {
position: relative;
height: 25px;
width: 25px;
}

.cards.cta.block > ul > li.hello-programs div {
border-color: var(--hello-programs);
.cards.cta.block .card-body p.link-container span.icon {
display: block;
width: 100%;
position: absolute;
left: 96%;
top: -5px;
}

.cards.cta.block > ul > li div p.image {
.cards.cta.block>ul>li div p.image {
width: 230px;
margin: 0 auto;
}

.cards.cta.block > ul > li picture {
.cards.cta.block>ul>li picture {
display: block;
position: relative;
height: 100%;
width: 100%;
}

.cards.cta.block > ul > li picture img {
position: absolute;
top: 0;
left: 0;
.cards.cta.block>ul>li picture img {
height: 100%;
width: 100%;
object-position: center center;
object-fit: contain;
}

.cards.cta.block > ul > li h3 {
.cards.cta.block>ul>li h3 {
font-size: var(--heading-font-size-xs);
text-align: center;
color: var(--gray);
margin: 12px auto;
text-align: left;
color: var(--gray-neutral-80);
margin-bottom:4px;
}

.cards.cta.block>ul>li p {
text-align: left;
}

.cards.cta.block > ul > li p {
text-align: center;
.cards.cta.block>ul>li p.link-container {
text-align: left;
}

.cards.cta.block > ul > li p.button-container {
margin: 18px auto;
.cards.cta.block>ul>li p.button-container {
text-align: left;
margin-top:auto;
}

@media screen and (min-width: 900px) {
Expand All @@ -73,24 +104,40 @@
grid-template-columns: 1fr 1fr 1fr;
}

.cards.cta.block > ul > li > div {
.cards.cta.block ul.cards-4 {
grid-template-columns: repeat(4, 1fr);
}

.cards.cta.block>ul>li>div {
display: flex;
flex-direction: column;
justify-content: stretch;
height: 100%;
}

.cards.cta.block > ul > li > div > * {
flex-basis: 33%;
.cards.cta.block>ul>li>div>* {

}

.cards.cta.block > ul > li div p.image {
.cards.cta.block>ul>li div p.image {
width: 100%;
}

.cards.cta.block .card-body {

}

.cards.cta.block .card-body p.link-container span.icon {
display: block;
width: 100%;
position: absolute;
left: 96%;
top: -5px;
}
}

@media screen and (min-width: 1200px) {
.cards.cta.block > ul > li div p.image {
width: 230px;
.cards.cta.block>ul>li div p.image {
width: 100%;
}
}
21 changes: 15 additions & 6 deletions blocks/cards/cta.js
Original file line number Diff line number Diff line change
@@ -1,26 +1,35 @@
import { decorateIcons } from '../../scripts/lib-franklin.js';
import { decorateIcons } from '../../scripts/aem.js';

Check failure on line 1 in blocks/cards/cta.js

View workflow job for this annotation

GitHub Actions / build

'decorateIcons' is defined but never used

/**
* Builds the CTA variation of the cards block.
* @param {HTMLDivElement} block
*/
export default async function decorate(block) {
const cards = [...block.children];
const anchor = block.querySelector('a');
anchor.classList.remove('button', 'primary');
anchor.classList.add('top-link');
const ul = document.createElement('ul');
ul.classList.add(`cards-${cards.length}`);
cards.forEach((card) => {
const topSection = document.createElement('div');
topSection.classList.add('top-section');
const cardBody = (card.children[1]);
cardBody.classList.add('card-body');
const ButtonContainer = card.querySelector('p.button-container');
ButtonContainer.classList.add('link-container');
cardBody.prepend(topSection);
const topLink = card.querySelector('p.link-container');

Check failure on line 22 in blocks/cards/cta.js

View workflow job for this annotation

GitHub Actions / build

'topLink' is assigned a value but never used
/* cardBody.append(topLink); */
const li = document.createElement('li');
li.classList.add('cta', card.children[0].textContent);
li.append(card.children[1]);

const picture = li.querySelector('picture');
picture.closest('p').classList.add('image');

const img = picture.querySelector('img');
const ratio = (parseInt(img.height, 10) / parseInt(img.width, 10)) * 100;
picture.style.paddingBottom = `${ratio}%`;
const ratio = (parseInt(img.height, 10) / parseInt(img.width, 10)) * 0;
img.style.marginBottom = `${ratio}%`;
ul.append(li);
});
block.replaceChildren(ul);
await decorateIcons(block);
}
3 changes: 1 addition & 2 deletions blocks/cards/icon-cta.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { decorateIcons } from '../../scripts/lib-franklin.js';
import { decorateIcons } from '../../scripts/aem.js';

Check failure on line 1 in blocks/cards/icon-cta.js

View workflow job for this annotation

GitHub Actions / build

'decorateIcons' is defined but never used

/**
* Builds the Icons variation of the cards block.
Expand Down Expand Up @@ -43,5 +43,4 @@
card.append(content, link);
});
});
await decorateIcons(block);
}
50 changes: 44 additions & 6 deletions blocks/cards/icon.css
Original file line number Diff line number Diff line change
@@ -1,27 +1,44 @@

.cards.icon.block {
display: grid;
gap: 24px;
max-width:1200px;
margin:auto;
}

.cards-wrapper {
max-width: var(--normal-page-width);
}

.cards.icon.block .row {
display: grid;
gap: 24px;
}


.cards.icon.block .card {
display: flex;
padding: 20px 30px;
padding-right:20px;
margin:20px 0;
flex-direction: column;
background-color: white;
box-shadow: 0 4px 10px 0 rgba(0 0 0 / 20%);
border-radius: 10px;
text-align: center;
border-bottom: 1px solid grey;
}

.cards.icon.block .card span.icon {
display: inline-block;
height: 43px;
width: 43px;
height: 70px;
width: 70px;
margin-bottom:1em;
}

.cards.icon.block .card .button-container span.icon {
position: relative;
top: 8px;
left: 10px;
display: inline-block;
height: 25px;
width: 25px;
}

.cards.icon.block .card span.icon svg {
Expand All @@ -30,18 +47,38 @@
width: 100%;
}

.cards.icon.block .card:last-of-type {
border:0;
}

.cards.icon.block .card h3 {
margin-bottom: 1em;
font-size: var(--heading-font-size-xs);
font-weight: var(--font-weight-bold);
line-height: var(--line-height-s);
}

.cards.icon.block .card p {
margin-bottom:0;

}
@media screen and (min-width: 600px) {
.cards.icon.block .card {

}
}

@media screen and (min-width: 900px) {
.cards.icon.block .row {
grid-template-columns: repeat(2, 1fr);
}

.cards.icon.block .card {
border-right: 1px solid grey;
border-bottom:0;

}

main .section[data-layout] .cards.icon.block .row {
grid-template-columns: 1fr;
}
Expand All @@ -52,4 +89,5 @@
main .section[data-layout] .cards.icon.block .row {
grid-template-columns: repeat(3, 1fr);
}

}
3 changes: 1 addition & 2 deletions blocks/cards/icon.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { decorateIcons } from '../../scripts/lib-franklin.js';
import { decorateIcons } from '../../scripts/aem.js';

Check failure on line 1 in blocks/cards/icon.js

View workflow job for this annotation

GitHub Actions / build

'decorateIcons' is defined but never used

export default async function decorate(block) {
let count;
Expand All @@ -13,5 +13,4 @@
card.classList.add('card');
});
});
await decorateIcons(block);
}
Loading
Loading