Bump Auth/Account to 1.0.3 and Order to 1.0.4 #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Ferri0
changed the title
Ferri0
approved these changes
Feb 6, 2025
Ferri0
approved these changes
Feb 6, 2025
sirugh
approved these changes
Feb 6, 2025
| @@ -187,6 +187,31 @@ export default async function decorate(block) { | |||
|
|
|||
| block.appendChild(checkoutFragment); | |||
|
|
|||
| const authPrivacyPolicyConsentSlot = { | |||
| PrivacyPolicyConsent: async (ctx) => { | |||
There was a problem hiding this comment.
This seems to be same content used in commerce-create-account.js. Can you dedupe?
There was a problem hiding this comment.
Moved to scripts/constants.js 👍
| }); | ||
|
|
||
| const link = document.createElement('a'); | ||
| link.href = '/privacy-policy'; |
There was a problem hiding this comment.
These are defined in scripts/constants.js
There was a problem hiding this comment.
Moved to scripts/constants.js
…ate-commerce into auth-combine-focus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deliver latest versions of auth, account and order dropins
Add content for privacy policy consent slot
Sign-up page
Checkout page
Order confirmation page
Improve AuthCombine modal accessibility
Ticket - https://jira.corp.adobe.com/browse/USF-1959
Screen.Recording.2025-02-03.at.13.27.45-1.mov
Test URLs: