-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LYNX-670: Sidekick plugin for browsing and combining personalisation criteria #281
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @bl4de ! Please see my comment
tools/segments/src/index.js
Outdated
/** | ||
* Default configuration to be loaded. | ||
*/ | ||
const defaultConfig = 'dev'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default config has to be changed for staging testing before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR @bl4de
"edit" | ||
], | ||
"url": "https://main--aem-boilerplate-commerce--hlxsites.hlx.live/tools/picker/dist/index.html", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have suggested you use aem.live
urls in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sirugh , that was the original url I have copied from existing Commerce
plugin - should I change it in both plugins?
}, | ||
{ | ||
"key": "commerce-endpoint", | ||
"value": "http://adobecommerce247.local/graphql" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this specific to your own setup? Are there instructions for how to update/change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sirugh, thanks for your feedback - yes, that is my local instance I was using during development, I will restore the original one.
This PR implements AEM Sidekick plugin for for browsing and combining personalisation criteria.
See https://jira.corp.adobe.com/browse/LYNX-670 for details.
Test URLs: