Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LYNX-670: Sidekick plugin for browsing and combining personalisation criteria #281

Merged
merged 20 commits into from
Jan 28, 2025

Conversation

bl4de
Copy link
Collaborator

@bl4de bl4de commented Jan 22, 2025

This PR implements AEM Sidekick plugin for for browsing and combining personalisation criteria.
See https://jira.corp.adobe.com/browse/LYNX-670 for details.

Test URLs:

Copy link

aem-code-sync bot commented Jan 22, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot requested a deployment to LYNX-670 January 27, 2025 10:54 Queued
@bl4de bl4de marked this pull request as ready for review January 27, 2025 11:16
Copy link
Collaborator

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @bl4de ! Please see my comment

/**
* Default configuration to be loaded.
*/
const defaultConfig = 'dev';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default config has to be changed for staging testing before merge

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link

aem-code-sync bot commented Jan 28, 2025

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@loginesta loginesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @bl4de

@sivaschenko sivaschenko merged commit 88be2b6 into main Jan 28, 2025
3 checks passed
@sivaschenko sivaschenko deleted the LYNX-670 branch January 28, 2025 10:10
"edit"
],
"url": "https://main--aem-boilerplate-commerce--hlxsites.hlx.live/tools/picker/dist/index.html",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have suggested you use aem.live urls in this file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sirugh , that was the original url I have copied from existing Commerce plugin - should I change it in both plugins?

},
{
"key": "commerce-endpoint",
"value": "http://adobecommerce247.local/graphql"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this specific to your own setup? Are there instructions for how to update/change this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sirugh, thanks for your feedback - yes, that is my local instance I was using during development, I will restore the original one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants