Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedupe performCatalogServiceQuery #270

Closed
wants to merge 1 commit into from
Closed

Conversation

sirugh
Copy link
Collaborator

@sirugh sirugh commented Jan 6, 2025

The performCatalogServiceQuery was implemented 3 times. We only need one.
The main difference is that in the picker tool, GET is used, and in the pdp-metadata tool, POST is used.

Validation

The Picker and PDP Metadata tool should function as expected. Notably a "big" change is that now the config for the metadata tool is now fetched using getConfigValue calls rather than the logic in pdp-metadata.js

Test URLs:

Copy link

aem-code-sync bot commented Jan 6, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 6, 2025

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sirugh
Copy link
Collaborator Author

sirugh commented Jan 8, 2025

Closing as discussed with @herzog31 and we decided not to include dependency on web code (ie scripts/commerce) in picker for now.

@sirugh sirugh closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant