Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack safe recursion #259

Merged
merged 130 commits into from
Jan 24, 2025
Merged

Stack safe recursion #259

merged 130 commits into from
Jan 24, 2025

Conversation

CAG2Mark
Copy link
Contributor

@CAG2Mark CAG2Mark commented Jan 7, 2025 •
edited
Loading

Uses effect handlers to implement stack safe recursion.

Depends on #257, which should be merged first.

TODO:

  • Write more tests and check for bugs
  • __Return is currently leaked, which should be fixed
  • Don't rewrite trivial functions

AnsonYeung and others added 30 commits December 8, 2024 16:37
@AnsonYeung
Changes IR
9e2c4cd
@CAG2Mark
initial changes
e7813a9
@CAG2Mark
Update elaborator
4444d4e
@CAG2Mark
update lowering
4f26189
@CAG2Mark
fix whitespace
942922d
@CAG2Mark
refactor some code
827c5e7
@AnsonYeung
Simplify test cases
eef7131
@AnsonYeung
Hide handlers behind a flag
5b26719
@AnsonYeung
Implement transformation for non-resumptive effects
421b640
@AnsonYeung @CAG2Mark
Continuation class transformation
76695ba 
Co-authored-by: Mark Ng <[email protected]>
@AnsonYeung
Port tests to new branch
2263ddf
@AnsonYeung
Resume non tail resumptive handlers
bdbee0a
@AnsonYeung
Implement final pieces for nested handlers
e9bab2b
@AnsonYeung
Implement Match codegen for multiple arms
4bb2d73
@AnsonYeung
Moved most wiring code to Predef
7395b4c
@AnsonYeung
Changes to IR
5ef77f2
@AnsonYeung
Changes IR
018dedd
@AnsonYeung
Patch for JSBuilder
dac193e
@AnsonYeung
Fix link error
68be072
@AnsonYeung
Merge branch 'hkmc2' into ir-handler
ab69c37
@AnsonYeung
Changes to handler syntax
6a71972
@AnsonYeung
Add class inheritance in IR
ea621a9
@AnsonYeung
Add class inheritance in IR and fixed spacing
d07371e
@AnsonYeung
Merge branch 'hkmc2' into ir-handler
6b74a07
@AnsonYeung
Remove unnecessary newline in JS Codegen
be15486
@AnsonYeung
Random typo fix
db5aa6d
@AnsonYeung
Merge branch 'ir-handler' into ir-handler-transform
2b67aba
@AnsonYeung
Small fix
ef1eabc
@LPTK
Add mildly interesting test
61d2a27
@LPTK
Add more test cases and reveal some issues
564f020
@AnsonYeung
Copy link

The problem in the instrumentation is dealt with and tests look fine now.

@CAG2Mark
Copy link
Contributor Author

CAG2Mark commented Jan 23, 2025 •
edited
Loading

Should be good to go now

  • EDIT: actually there's one small change I want to make to make the tests a bit more consistent

@CAG2Mark CAG2Mark requested a review from LPTK January 23, 2025 14:38
LPTK
LPTK approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please address the comments and I'll make the merge!

hkmc2/shared/src/test/mlscript/handlers/ZCombinator.mls Outdated Show resolved Hide resolved
hkmc2/shared/src/main/scala/hkmc2/MLsCompiler.scala Outdated Show resolved Hide resolved
hkmc2/shared/src/main/scala/hkmc2/codegen/Block.scala Outdated Show resolved Hide resolved
hkmc2/shared/src/main/scala/hkmc2/codegen/Block.scala Outdated Show resolved Hide resolved
hkmc2/shared/src/main/scala/hkmc2/codegen/Block.scala Outdated Show resolved Hide resolved
hkmc2/shared/src/main/scala/hkmc2/codegen/HandlerLowering.scala Outdated Show resolved Hide resolved
hkmc2/shared/src/main/scala/hkmc2/codegen/HandlerLowering.scala Outdated Show resolved Hide resolved
hkmc2/shared/src/main/scala/hkmc2/codegen/StackSafeTransform.scala Outdated Show resolved Hide resolved
hkmc2/shared/src/main/scala/hkmc2/codegen/StackSafeTransform.scala Outdated Show resolved Hide resolved
hkmc2/shared/src/main/scala/hkmc2/codegen/StackSafeTransform.scala Outdated Show resolved Hide resolved
@LPTK LPTK merged commit dabeb54 into hkust-taco:hkmc2 Jan 24, 2025
1 check passed
@LPTK LPTK deleted the stack-safety branch January 24, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnsonYeung AnsonYeung AnsonYeung left review comments

@LPTK LPTK LPTK approved these changes

Assignees

@AnsonYeung AnsonYeung

@CAG2Mark CAG2Mark

Labels
effect-handlers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CAG2Mark @LPTK @AnsonYeung