Support integer literals of different radices and decimal numeric literals #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengluyu
changed the title
|
6182f20 failed for some reasons. Strange. |
Random-happened time-out problem lol. |
LPTK
approved these changes
Dec 31, 2023
Co-authored-by: Lionel Parreaux <[email protected]>
Co-authored-by: Lionel Parreaux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for various literals.
0xCAFE, etc.0o4567, etc.0b0010, etc.1e100,3.141592653589793, etc.0x0010_1101,12_34.56_78E+9_0, etc.\\,\b, and\f. (I forgot this so it's not indicated by my commit messages. 🤦♂️)Note
This PR does not support numeric literals starting with decimal points, for example,
.5, because it conflicts with selecting tuple indices. We can check the accumulated tokens to determine the meaning of tokens such as.1, but I don't have time to summarize various situations and add tests right now, so I will leave it for future work.